From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH] Added call parameter to track whether invocation originated with guest or elsewhere Date: Wed, 17 Oct 2012 16:28:09 +0200 Message-ID: <507EC079.3050908@redhat.com> References: <1350439833.8785.27.camel@WillAuldHomeLinux> <507E89F5.4000301@redhat.com> <20121017140918.GA4940@amt.cnet> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: will.auld@intel.com, Will Auld , kvm@vger.kernel.org, xiantao.zhang@intel.com, jinsong.liu@intel.com To: Marcelo Tosatti Return-path: Received: from mx1.redhat.com ([209.132.183.28]:52262 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756259Ab2JQO2Q (ORCPT ); Wed, 17 Oct 2012 10:28:16 -0400 In-Reply-To: <20121017140918.GA4940@amt.cnet> Sender: kvm-owner@vger.kernel.org List-ID: On 10/17/2012 04:09 PM, Marcelo Tosatti wrote: > On Wed, Oct 17, 2012 at 12:35:33PM +0200, Avi Kivity wrote: >> On 10/17/2012 04:10 AM, Will Auld wrote: >> > Signed-off-by: Will Auld >> > --- >> > >> > Resending to full list >> > >> > Marcelo, >> > >> > This patch is what I believe you ask for as foundational for later >> > patches to address IA32_TSC_ADJUST. >> > >> >> Please write a changelog to reflect the motivation. >> >> All those bool parameters scattered all over the place aren't very >> pretty. Usually we solve this with helpers that embed the parameter >> name (kvm_set_msr() vs. kvm_set_msr_host()) but there are too many >> functions for this to work here. >> >> Marcelo, any ideas? > > Its easier to read > > kvm_x86_ops->kvm_set_msr() > kvm_x86_ops->kvm_set_msr_host() > > then > > kvm_x86_ops->kvm_set_msr(,false) > kvm_x86_ops->kvm_set_msr(,true) > > So you're right. Yes, but we have a million functions for setting MSRs. Maybe struct msr { bool host_requested; u32 index; u64 data; }; and change all the APIs to use that. -- error compiling committee.c: too many arguments to function