From mboxrd@z Thu Jan  1 00:00:00 1970
From: Glauber Costa <glommer@parallels.com>
Subject: Re: [patch 11/18] x86: vsyscall: pass mode to gettime backend
Date: Tue, 30 Oct 2012 11:42:46 +0400
Message-ID: <508F84F6.6090302@parallels.com>
References: <20121024131340.742340256@redhat.com> <20121024131621.792772220@redhat.com> <508E971D.8030108@parallels.com> <20121029184106.GB30422@amt.cnet>
Mime-Version: 1.0
Content-Type: text/plain; charset="ISO-8859-1"
Content-Transfer-Encoding: 7bit
Cc: <kvm@vger.kernel.org>, <johnstul@us.ibm.com>, <jeremy@goop.org>,
	<zamsden@gmail.com>, <gleb@redhat.com>, <avi@redhat.com>,
	<pbonzini@redhat.com>
To: Marcelo Tosatti <mtosatti@redhat.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from mx2.parallels.com ([64.131.90.16]:37119 "EHLO mx2.parallels.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1755954Ab2J3Hm4 (ORCPT <rfc822;kvm@vger.kernel.org>);
	Tue, 30 Oct 2012 03:42:56 -0400
In-Reply-To: <20121029184106.GB30422@amt.cnet>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

On 10/29/2012 10:41 PM, Marcelo Tosatti wrote:
> On Mon, Oct 29, 2012 at 06:47:57PM +0400, Glauber Costa wrote:
>> On 10/24/2012 05:13 PM, Marcelo Tosatti wrote:
>>> Required by next patch.
>>>
>>> Signed-off-by: Marcelo Tosatti <mtosatti@redhat.com>
>> I don't see where.
> 
> +       if (unlikely(!(flags & PVCLOCK_TSC_STABLE_BIT)))
> +               *mode = VCLOCK_NONE;
> 
> 

I see. But I end up thinking that this is a case of oversimplification
that gets things more complicated =)

If this would be folded in the next patch, this would be obvious.