From mboxrd@z Thu Jan  1 00:00:00 1970
From: Glauber Costa <glommer@parallels.com>
Subject: Re: [patch 09/16] x86: kvm guest: pvclock vsyscall support
Date: Fri, 2 Nov 2012 13:42:41 +0400
Message-ID: <50939591.7000809@parallels.com>
References: <20121031224656.417434866@redhat.com> <20121031224824.243464587@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="ISO-8859-1"
Content-Transfer-Encoding: 7bit
Cc: <kvm@vger.kernel.org>, <johnstul@us.ibm.com>, <jeremy@goop.org>,
	<zamsden@gmail.com>, <gleb@redhat.com>, <avi@redhat.com>,
	<pbonzini@redhat.com>
To: Marcelo Tosatti <mtosatti@redhat.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from mx2.parallels.com ([64.131.90.16]:38753 "EHLO mx2.parallels.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1757703Ab2KBJmy (ORCPT <rfc822;kvm@vger.kernel.org>);
	Fri, 2 Nov 2012 05:42:54 -0400
In-Reply-To: <20121031224824.243464587@redhat.com>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

On 11/01/2012 02:47 AM, Marcelo Tosatti wrote:
> +	info = pvclock_get_vsyscall_time_info(cpu);
> +
> +	low = (int)__pa(info) | 1;
> +	high = ((u64)__pa(&per_cpu(hv_clock, cpu)) >> 32);
> +	ret = native_write_msr_safe(MSR_KVM_USERSPACE_TIME, low, high);
> +	printk(KERN_INFO "kvm-clock: cpu %d, msr %x:%x, %s\n",
> +	       cpu, high, low, txt);
> +

Why do you put info in the lower half, and the hv_clock in the higher half ?