From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paolo Bonzini Subject: Re: [PATCH 3/3] apic: always update the in-kernel status after loading Date: Fri, 02 Nov 2012 16:21:23 +0100 Message-ID: <5093E4F3.2060904@redhat.com> References: <1967551787.5579995.1351869188109.JavaMail.root@redhat.com> <5093E3F2.20007@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Cc: Avi Kivity , qemu-devel@nongnu.org, mtosatti@redhat.com, kvm@vger.kernel.org, Jan Kiszka To: Gerd Hoffmann Return-path: Received: from mx1.redhat.com ([209.132.183.28]:7531 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753966Ab2KBPVb (ORCPT ); Fri, 2 Nov 2012 11:21:31 -0400 In-Reply-To: <5093E3F2.20007@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: Il 02/11/2012 16:17, Gerd Hoffmann ha scritto: > On 11/02/12 16:13, Paolo Bonzini wrote: >>> >> Hi, >>> >> >>>> >>> I think deferring IRQ events to the point when the complete vmstate >>>> >>> is loaded is the cleaner and more robust approach. >>> >> >>> >> Agree. Just schedule a bh in post_load. >>> >> See also a229c0535bd336efaec786dd6e352a54e0a8187d >> > >> > No, it cannot a bh. Right now incoming migration is blocking, >> > but this will change in 1.3. There is no guarantee that a >> > bottom half will run after migration has completed. > Then we'll need some new way to do this, maybe a new post_load handler > which is called once _all_ state is loaded. The simplest is a vm_clock timer that expires at time 0. Paolo