From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sasha Levin Subject: Re: [RFC PATCH 14/16] kvm tools: teach guest_flat_to_host about memory banks starting above 0 Date: Mon, 12 Nov 2012 23:47:37 -0500 Message-ID: <50A1D0E9.9010008@gmail.com> References: <1352721450-11340-1-git-send-email-will.deacon@arm.com> <1352721450-11340-15-git-send-email-will.deacon@arm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: kvm@vger.kernel.org, penberg@kernel.org, marc.zyngier@arm.com, c.dall@virtualopensystems.com, matt.evans@arm.com, peter.maydell@linaro.org To: Will Deacon Return-path: Received: from mail-vb0-f46.google.com ([209.85.212.46]:51176 "EHLO mail-vb0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752290Ab2KMEr7 (ORCPT ); Mon, 12 Nov 2012 23:47:59 -0500 Received: by mail-vb0-f46.google.com with SMTP id ff1so7086149vbb.19 for ; Mon, 12 Nov 2012 20:47:58 -0800 (PST) In-Reply-To: <1352721450-11340-15-git-send-email-will.deacon@arm.com> Sender: kvm-owner@vger.kernel.org List-ID: On 11/12/2012 06:57 AM, Will Deacon wrote: > Running a guest with multiple banks of memory based above 0 causes the > guest_flat_to_host address conversion to fail, as it is assumed that > guest memory addresses are offset linearly from 0. > > This patch changes the translation function so that the kvm_mem_bank > structures registered by kvm__register_mem are used to translate guest > addresses, rather than use an offset from the start of host memory. > > Signed-off-by: Will Deacon > --- Hmm... we probably need something to teach E820 about this new memory layout thingie if we start mapping multiple memory banks. Not urgent for now though - I guess. Thanks, Sasha