From mboxrd@z Thu Jan  1 00:00:00 1970
From: Sasha Levin <levinsasha928@gmail.com>
Subject: Re: [PATCH v2 1/8] rbtree: include linux/compiler.h for definition
 of __always_inline
Date: Thu, 22 Nov 2012 13:44:34 -0500
Message-ID: <50AE7292.60901@gmail.com>
References: <1353599897-15656-1-git-send-email-will.deacon@arm.com> <1353599897-15656-2-git-send-email-will.deacon@arm.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Cc: kvm@vger.kernel.org, penberg@kernel.org, marc.zyngier@arm.com,
	c.dall@virtualopensystems.com, matt@ozlabs.org,
	peter.maydell@linaro.org, michael@ellerman.id.au,
	kvmarm@lists.cs.columbia.edu, Ingo Molnar <mingo@elte.hu>,
	Andrew Morton <akpm@linux-foundation.org>,
	Linus Torvalds <torvalds@linux-foundation.org>
To: Will Deacon <will.deacon@arm.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from mail-qc0-f174.google.com ([209.85.216.174]:49475 "EHLO
	mail-qc0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1754673Ab2KVSpM (ORCPT <rfc822;kvm@vger.kernel.org>);
	Thu, 22 Nov 2012 13:45:12 -0500
Received: by mail-qc0-f174.google.com with SMTP id o22so5921027qcr.19
        for <kvm@vger.kernel.org>; Thu, 22 Nov 2012 10:45:11 -0800 (PST)
In-Reply-To: <1353599897-15656-2-git-send-email-will.deacon@arm.com>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

On 11/22/2012 10:58 AM, Will Deacon wrote:
> Commit 29fc7c5a4f516d388fb6e1f6d24bfb04b8093e54 upstream.
> 
> rb_erase_augmented() is a static function annotated with
> __always_inline.  This causes a compile failure when attempting to use
> the rbtree implementation as a library (e.g.  kvm tool):
> 
>   rbtree_augmented.h:125:24: error: expected `=', `,', `;', `asm' or `__attribute__' before `void'

On a side note, our rbtree-interval is broken at the moment due to kernel side
changing the implementation and (IMO) breaking augmented rbtrees, followed
by several patches in our own code that tried to fix the breakage but haven't
identified the problem correctly - leading to more subtle breakage.

If you see things broken with mmio, that might be the reason.

I have a fix for that which goes to both kernel and our code, but I'm
waiting to verify that the kernel side is indeed broken.


Thanks,
Sasha