From mboxrd@z Thu Jan 1 00:00:00 1970 From: Orit Wasserman Subject: Re: [PATCH v2 4/4] nested vmx: use a list to store the launched vmcs12 for L1 VMM Date: Wed, 28 Nov 2012 14:30:17 +0200 Message-ID: <50B603D9.10702@redhat.com> References: <1353559919-29439-1-git-send-email-dongxiao.xu@intel.com> <1353559919-29439-5-git-send-email-dongxiao.xu@intel.com> <20121128002908.GD8295@amt.cnet> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: Dongxiao Xu , kvm@vger.kernel.org, gleb@redhat.com To: Marcelo Tosatti Return-path: Received: from mx1.redhat.com ([209.132.183.28]:21144 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754584Ab2K1M3p (ORCPT ); Wed, 28 Nov 2012 07:29:45 -0500 In-Reply-To: <20121128002908.GD8295@amt.cnet> Sender: kvm-owner@vger.kernel.org List-ID: On 11/28/2012 02:29 AM, Marcelo Tosatti wrote: > On Thu, Nov 22, 2012 at 12:51:59PM +0800, Dongxiao Xu wrote: >> The launch state is not a member in the VMCS area, use a separate >> variable (list) to store it instead. >> >> Signed-off-by: Dongxiao Xu > > 1. What is the problem with keeping launched state in the VMCS? > Assuming there is a positive answer to the above: > > 2. Don't you have to change VMCS ID? > > 3. Can't it be kept somewhere else other than a list? Current scheme > allows guest to allocate unlimited amounts of host memory. I agree with Marcelo you have to limit the number of VMCS in the list otherwise it will be easy to attack a host with nested :) > > 4. What is the state of migration / nested vmx again? If vmcs12 is > migrated, this means launched state is not migrated anymore. > > Patches 1-3 seem fine. > > -- > To unsubscribe from this list: send the line "unsubscribe kvm" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html >