From: Avi Kivity <avi.kivity@gmail.com>
To: Marcelo Tosatti <mtosatti@redhat.com>, Gleb Natapov <gleb@redhat.com>
Cc: kvm@vger.kernel.org
Subject: Re: [PATCH v2 6/7] KVM: x86 emulator: add macros for defining 2-operand fastop emulation
Date: Fri, 04 Jan 2013 14:57:21 +0200 [thread overview]
Message-ID: <50E6D1B1.4050101@gmail.com> (raw)
In-Reply-To: <1357296459-8951-7-git-send-email-avi.kivity@gmail.com>
On 01/04/2013 12:47 PM, Avi Kivity wrote:
> Signed-off-by: Avi Kivity <avi.kivity@gmail.com>
> ---
> arch/x86/kvm/emulate.c | 12 ++++++++++++
> 1 file changed, 12 insertions(+)
>
> diff --git a/arch/x86/kvm/emulate.c b/arch/x86/kvm/emulate.c
> index 09dbdc5..9a39689 100644
> --- a/arch/x86/kvm/emulate.c
> +++ b/arch/x86/kvm/emulate.c
> @@ -465,6 +465,17 @@ static void invalidate_registers(struct x86_emulate_ctxt *ctxt)
> ON64(FOP1E(op##q, rax)) \
> FOP_END
>
> +#define FOP2E(op, dst, src) \
> + FOP_ALIGN #op " %" #dst ", %" #src " \n\t" FOP_RET
> +
>
This can't be right, the operand order is reversed.
next prev parent reply other threads:[~2013-01-04 12:57 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-04 10:47 [PATCH v2 0/7] Streamline arithmetic instruction emulation Avi Kivity
2013-01-04 10:47 ` [PATCH v2 1/7] KVM: x86 emulator: framework for streamlining arithmetic opcodes Avi Kivity
2013-01-04 10:47 ` [PATCH v2 2/7] KVM: x86 emulator: Support for declaring single operand fastops Avi Kivity
2013-01-04 10:47 ` [PATCH v2 3/7] KVM: x86 emulator: introduce NoWrite flag Avi Kivity
2013-01-04 10:47 ` [PATCH v2 4/7] KVM: x86 emulator: mark CMP, CMPS, SCAS, TEST as NoWrite Avi Kivity
2013-01-04 10:47 ` [PATCH v2 5/7] KVM: x86 emulator: convert NOT, NEG to fastop Avi Kivity
2013-01-04 10:47 ` [PATCH v2 6/7] KVM: x86 emulator: add macros for defining 2-operand fastop emulation Avi Kivity
2013-01-04 12:57 ` Avi Kivity [this message]
2013-01-04 10:47 ` [PATCH v2 7/7] KVM: x86 emulator: convert basic ALU ops to fastop Avi Kivity
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50E6D1B1.4050101@gmail.com \
--to=avi.kivity@gmail.com \
--cc=gleb@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=mtosatti@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox