From mboxrd@z Thu Jan  1 00:00:00 1970
From: Avi Kivity <avi.kivity@gmail.com>
Subject: Re: [PATCH v2 6/7] KVM: x86 emulator: add macros for defining 2-operand
 fastop emulation
Date: Fri, 04 Jan 2013 14:57:21 +0200
Message-ID: <50E6D1B1.4050101@gmail.com>
References: <1357296459-8951-1-git-send-email-avi.kivity@gmail.com> <1357296459-8951-7-git-send-email-avi.kivity@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Cc: kvm@vger.kernel.org
To: Marcelo Tosatti <mtosatti@redhat.com>,
	Gleb Natapov <gleb@redhat.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from mail-bk0-f52.google.com ([209.85.214.52]:48639 "EHLO
	mail-bk0-f52.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1754600Ab3ADM5Z (ORCPT <rfc822;kvm@vger.kernel.org>);
	Fri, 4 Jan 2013 07:57:25 -0500
Received: by mail-bk0-f52.google.com with SMTP id w5so7198970bku.11
        for <kvm@vger.kernel.org>; Fri, 04 Jan 2013 04:57:24 -0800 (PST)
In-Reply-To: <1357296459-8951-7-git-send-email-avi.kivity@gmail.com>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

On 01/04/2013 12:47 PM, Avi Kivity wrote:
> Signed-off-by: Avi Kivity <avi.kivity@gmail.com>
> ---
>  arch/x86/kvm/emulate.c | 12 ++++++++++++
>  1 file changed, 12 insertions(+)
>
> diff --git a/arch/x86/kvm/emulate.c b/arch/x86/kvm/emulate.c
> index 09dbdc5..9a39689 100644
> --- a/arch/x86/kvm/emulate.c
> +++ b/arch/x86/kvm/emulate.c
> @@ -465,6 +465,17 @@ static void invalidate_registers(struct x86_emulate_ctxt *ctxt)
>  	ON64(FOP1E(op##q, rax))	\
>  	FOP_END
>  
> +#define FOP2E(op,  dst, src)	   \
> +	FOP_ALIGN #op " %" #dst ", %" #src " \n\t" FOP_RET
> +
>

This can't be right, the operand order is reversed.