From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?ISO-8859-15?Q?Andreas_F=E4rber?= Subject: Re: What to do about non-qdevified devices? Date: Wed, 30 Jan 2013 09:39:07 +0100 Message-ID: <5108DC2B.2000204@suse.de> References: <871ud4gfoa.fsf@elfo.elfo> <510836DD.3010707@suse.de> <87sj5j7jo8.fsf@codemonkey.ws> <87pq0n887o.fsf_-_@blackfin.pond.sub.org> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: Alexander Graf , Juan Quintela , qemu-devel qemu-devel , KVM devel mailing list , Paolo Bonzini , Blue Swirl To: Markus Armbruster , Anthony Liguori Return-path: Received: from cantor2.suse.de ([195.135.220.15]:35225 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751285Ab3A3IjR (ORCPT ); Wed, 30 Jan 2013 03:39:17 -0500 In-Reply-To: <87pq0n887o.fsf_-_@blackfin.pond.sub.org> Sender: kvm-owner@vger.kernel.org List-ID: Am 30.01.2013 08:02, schrieb Markus Armbruster: > Anthony Liguori writes: >=20 > [...] >> The problems I ran into were (1) this is a lot of work (2) it basica= lly >> requires that all bus children have been qdev/QOM-ified. Even with >> something like the ISA bus which is where I started, quite a few dev= ices >> were not qdevified still. >=20 > So what's the plan to complete the qdevification job? Lay really low > and quietly hope the problem goes away? We've tried that for about > three years, doesn't seem to work. Stating (file) names would make that discussion much easier... ;) I'd expect non-qdev'ified devices to rather be SysBusDevices (e.g., m68k, sh4, ppc). PReP's pc87312 qdev'ification was forgotten for 1.2 an= d recently merged. Would dma.c be a candidate for ISADevice? It uses isa_* API. (The stubs in sun4m.c/sun4u.c due to use in fdc.c might be a candidate for stubs/ at least, short of an fdc.c rewrite.) I recently went through all ISADevices and QOM'ified them: https://lists.gnu.org/archive/html/qemu-devel/2012-11/msg02746.html It became too late for 1.4 and I'm not quite sure where Anthony wanted to draw the line between his 1) and 2): https://lists.gnu.org/archive/html/qemu-devel/2013-01/msg00071.html Thus I've only been rebasing my queue [1] without sending a v2 so far. Lack of an official ISA maintainer for reviewing is another issue, any volunteers? :) Cheers, Andreas [1] https://github.com/afaerber/qemu-cpu/commits/realize-isa --=20 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrn= berg