From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jason Wang Subject: Re: [Qemu-devel] [PATCH V4 00/22] Multiqueue virtio-net Date: Thu, 31 Jan 2013 15:00:38 +0800 Message-ID: <510A1696.6050409@redhat.com> References: <1359544361-5089-1-git-send-email-jasowang@redhat.com> <5109669F.5010405@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Cc: aliguori@us.ibm.com, mst@redhat.com, qemu-devel@nongnu.org, blauwirbel@gmail.com, shajnocz@redhat.com, krkumar2@in.ibm.com, kvm@vger.kernel.org, mprivozn@redhat.com, rusty@rustcorp.com.au, shiyer@redhat.com, jwhan@filewood.snu.ac.kr, gaowanlong@cn.fujitsu.com To: Eric Blake Return-path: Received: from mx1.redhat.com ([209.132.183.28]:30621 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752500Ab3AaHBR (ORCPT ); Thu, 31 Jan 2013 02:01:17 -0500 In-Reply-To: <5109669F.5010405@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On 01/31/2013 02:29 AM, Eric Blake wrote: > On 01/30/2013 04:12 AM, Jason Wang wrote: > >> With this changes, user could start a multiqueue virtio-net device through >> >> ./qemu -netdev tap,id=hn0,queues=2,vhost=on -device virtio-net-pci,netdev=hn0 >> >> Management tools such as libvirt can pass multiple pre-created fds/vhostfds through >> >> ./qemu -netdev tap,id=hn0,fds=X:Y,vhostfds=M:N -device virtio-net-pci,netdev=hn0 > Do we really need specific fds= parsing, or can we reuse the existing > -add-fd command line option to our advantage? I guess what I'm asking > is how hotplug will work; and if hotplug takes a file name, shouldn't > the command line also take a name; and if the command line takes a name, > what's wrong with: > > ./qemu -add-fd fdset=1,fd=X -add-fd fdset=2,fd=Y -add-fd fdset=3,fd=M > -add-fd fdset=4,fd=N -netdev > tap,id=hn0,fds=/dev/fdset/1:/dev/fdset/2,vhostfds=/dev/fdset/3:/dev/fdset/4 > -device virtio-net-pci,netdev=hn0 > AFAIK, tap does not support fdset now, so this requirement is beyond the scope of multiqueue itself. We can do this in the future. Btw does libvirt support add-fd now? For hotplug, it just work if you pass multiple file descriptors one by one through getfd and then use fds=X:Y,vhostfds=M:N.