From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?ISO-8859-1?Q?Andreas_F=E4rber?= Subject: Re: [kvmarm] [RFC v5 7/8] hw/kvm/arm_gic: Implement support for KVM in-kernel ARM GIC Date: Thu, 31 Jan 2013 11:54:49 +0100 Message-ID: <510A4D79.7010107@suse.de> References: <1359042240-11482-1-git-send-email-peter.maydell@linaro.org> <1359042240-11482-8-git-send-email-peter.maydell@linaro.org> <510A4CF5.9050006@greensocs.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: =?ISO-8859-1?Q?KONRAD_Fr=E9d=E9ric?= , qemu-devel@nongnu.org, Gleb Natapov , kvm@vger.kernel.org, patches@linaro.org, Marcelo Tosatti , kvmarm@lists.cs.columbia.edu, Blue Swirl , Christoffer Dall To: Peter Maydell Return-path: Received: from cantor2.suse.de ([195.135.220.15]:32925 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754552Ab3AaKy6 (ORCPT ); Thu, 31 Jan 2013 05:54:58 -0500 In-Reply-To: <510A4CF5.9050006@greensocs.com> Sender: kvm-owner@vger.kernel.org List-ID: Am 31.01.2013 11:52, schrieb KONRAD Fr=E9d=E9ric: > On 24/01/2013 16:43, Peter Maydell wrote: >> Implement support for using the KVM in-kernel GIC for ARM. >> >> Signed-off-by: Peter Maydell >> --- >> hw/a15mpcore.c | 8 ++- >> hw/arm/Makefile.objs | 1 + >> hw/kvm/arm_gic.c | 169 >> ++++++++++++++++++++++++++++++++++++++++++++++++++ >> 3 files changed, 177 insertions(+), 1 deletion(-) >> create mode 100644 hw/kvm/arm_gic.c >> >> diff --git a/hw/a15mpcore.c b/hw/a15mpcore.c >> index fe6c34c..1ca6f28 100644 >> --- a/hw/a15mpcore.c >> +++ b/hw/a15mpcore.c >> @@ -19,6 +19,7 @@ >> */ >> #include "sysbus.h" >> +#include "sysemu/kvm.h" >> /* A15MP private memory region. */ >> @@ -40,8 +41,13 @@ static int a15mp_priv_init(SysBusDevice *dev) >> { >> A15MPPrivState *s =3D FROM_SYSBUS(A15MPPrivState, dev); >> SysBusDevice *busdev; >> + const char *gictype =3D "arm-gic"; > s/arm-gic/arm_gic/ ^^ ? >=20 > Christoffer and I had trouble with that: >=20 > qemu-system-arm: Unknown device 'arm-gic' for default sysbus Since you already ran into issues here, even better would be to use a TYPE_ARM_GIC constant or so. Andreas >=20 > Fred >> - s->gic =3D qdev_create(NULL, "arm_gic"); >> + if (kvm_irqchip_in_kernel()) { >> + gictype =3D "kvm-arm-gic"; >> + } >> + >> + s->gic =3D qdev_create(NULL, gictype); >> qdev_prop_set_uint32(s->gic, "num-cpu", s->num_cpu); >> qdev_prop_set_uint32(s->gic, "num-irq", s->num_irq); >=20 --=20 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrn= berg