From mboxrd@z Thu Jan 1 00:00:00 1970 From: Eric Blake Subject: Re: [PATCH V4 00/22] Multiqueue virtio-net Date: Thu, 31 Jan 2013 08:18:51 -0700 Message-ID: <510A8B5B.8080104@redhat.com> References: <1359544361-5089-1-git-send-email-jasowang@redhat.com> <5109669F.5010405@redhat.com> <510A1696.6050409@redhat.com> <510A7551.9010304@redhat.com> <20130131135835.GA5707@redhat.com> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="----enig2GNHXQKTIBDGOJHQSSDAE" Cc: krkumar2@in.ibm.com, aliguori@us.ibm.com, kvm@vger.kernel.org, mprivozn@redhat.com, Jason Wang , rusty@rustcorp.com.au, qemu-devel@nongnu.org, blauwirbel@gmail.com, shajnocz@redhat.com, gaowanlong@cn.fujitsu.com, jwhan@filewood.snu.ac.kr, shiyer@redhat.com To: "Michael S. Tsirkin" Return-path: In-Reply-To: <20130131135835.GA5707@redhat.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+gceq-qemu-devel=gmane.org@nongnu.org Sender: qemu-devel-bounces+gceq-qemu-devel=gmane.org@nongnu.org List-Id: kvm.vger.kernel.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) ------enig2GNHXQKTIBDGOJHQSSDAE Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 01/31/2013 06:58 AM, Michael S. Tsirkin wrote: >>> For hotplug, it just work if you pass multiple file descriptors one b= y >>> one through getfd and then use fds=3DX:Y,vhostfds=3DM:N. >> >> For hotplug, you can't pass integers; you have to name the fds either >> way. Either you name it with getfd, or you name it with add-fd. But >> getfd is not as nice as add-fd when it comes to ensuring that fds are >> not leaked in qemu, even when the management app such as libvirt >> restarts. Furthermore, if it is possible to specify taps by pathname >> instead of by fd inheritance, >=20 > I don't think there's a way to specify taps by pathname. Then using fds=3Dinteger:integer on the command line makes the most sense= , and QMP uses fds=3Dname:name where name was specified by 'getfd', and there is no way to wire up qemu_open() nor any need to use 'add-fd'. Okay, my question has been answered, your approach looks right now that I know more about how -netdev works to begin with. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org ------enig2GNHXQKTIBDGOJHQSSDAE Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.13 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJRCotbAAoJEKeha0olJ0NqgMIIAIZcxwBeqwlNCA8QVnD7rmkr bHRRUQF/AU8nX5qXn93mcsPA1KM2BiM3IxJ1DlcQZm4EMHrPnlFaLfv1EJOyR+7B Oxe7Ltv/tZPzkOUltN+LDFKLXXSqcKzaMITu2Rm2WRYI0fU0oU3XmT3KN1Dka1nn NTPcOcsWSxUEpqzQGSQqcgyub20ThOpKctSnnqpa17BHmhUj68zHi72q5S76yDne DO5BajhSkwj1pTeTW7bUtS8u6NvmDLGFpOIdvvGEQV4p3d0jYik/fBC9M2Q9cm7d 7Ze3hPZg9EPD32uKTn7kd702/Tc5paU71Q8PK2P9SmLujdhpFKTFWeU9dQsbFrc= =DPWU -----END PGP SIGNATURE----- ------enig2GNHXQKTIBDGOJHQSSDAE--