From: "Andreas Färber" <afaerber@suse.de>
To: Jason Wang <jasowang@redhat.com>
Cc: aliguori@us.ibm.com, mst@redhat.com, qemu-devel@nongnu.org,
blauwirbel@gmail.com, shajnocz@redhat.com, krkumar2@in.ibm.com,
kvm@vger.kernel.org, mprivozn@redhat.com, rusty@rustcorp.com.au,
jwhan@filewood.snu.ac.kr, gaowanlong@cn.fujitsu.com,
Alexander Graf <agraf@suse.de>
Subject: Re: [Qemu-devel] [PATCH V4 RESEND 09/22] net: multiqueue support
Date: Tue, 12 Feb 2013 22:24:35 +0100 [thread overview]
Message-ID: <511AB313.4060405@suse.de> (raw)
In-Reply-To: <1359704396-55327-10-git-send-email-jasowang@redhat.com>
Am 01.02.2013 08:39, schrieb Jason Wang:
> diff --git a/net/net.c b/net/net.c
> index 98a1934..9806862 100644
> --- a/net/net.c
> +++ b/net/net.c
[...]
> @@ -271,9 +287,7 @@ static void qemu_cleanup_net_client(NetClientState *nc)
> {
> QTAILQ_REMOVE(&net_clients, nc, next);
>
> - if (nc->info->cleanup) {
> - nc->info->cleanup(nc);
> - }
> + nc->info->cleanup(nc);
> }
This change broke qemu-system-ppc64 -M pseries.
Why was the NULL guard dropped?
Andreas
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
next prev parent reply other threads:[~2013-02-12 21:24 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-01 7:39 [PATCH V4 RESEND 00/22] Multiqueue virtio-net Jason Wang
2013-02-01 7:39 ` [PATCH V4 RESEND 01/22] net: tap: using bool instead of bitfield Jason Wang
2013-02-01 7:39 ` [PATCH V4 RESEND 02/22] net: tap: use abort() instead of assert(0) Jason Wang
2013-02-01 7:39 ` [PATCH V4 RESEND 03/22] net: introduce qemu_get_queue() Jason Wang
2013-02-01 7:39 ` [PATCH V4 RESEND 04/22] net: introduce qemu_get_nic() Jason Wang
2013-02-01 7:39 ` [PATCH V4 RESEND 05/22] net: intorduce qemu_del_nic() Jason Wang
2013-02-01 18:00 ` Eric Blake
2013-02-01 7:39 ` [PATCH V4 RESEND 06/22] net: introduce qemu_find_net_clients_except() Jason Wang
2013-02-01 7:39 ` [PATCH V4 RESEND 07/22] net: introduce qemu_net_client_setup() Jason Wang
2013-02-01 7:39 ` [PATCH V4 RESEND 08/22] net: introduce NetClientState destructor Jason Wang
2013-02-01 7:39 ` [PATCH V4 RESEND 09/22] net: multiqueue support Jason Wang
2013-02-12 21:21 ` [Qemu-devel] " Alexander Graf
2013-02-19 7:45 ` Jason Wang
2013-02-12 21:24 ` Andreas Färber [this message]
2013-02-01 7:39 ` [PATCH V4 RESEND 10/22] tap: import linux multiqueue constants Jason Wang
2013-02-01 7:39 ` [PATCH V4 RESEND 11/22] tap: factor out common tap initialization Jason Wang
2013-02-01 7:39 ` [PATCH V4 RESEND 12/22] tap: add Linux multiqueue support Jason Wang
2013-02-01 7:39 ` [PATCH V4 RESEND 13/22] tap: support enabling or disabling a queue Jason Wang
2013-02-01 7:39 ` [PATCH V4 RESEND 14/22] tap: introduce a helper to get the name of an interface Jason Wang
2013-02-01 7:39 ` [PATCH V4 RESEND 15/22] tap: multiqueue support Jason Wang
2013-02-01 22:43 ` [Qemu-devel] " Eric Blake
2013-02-11 10:28 ` Markus Armbruster
2013-02-20 9:28 ` [Qemu-devel] " Jason Wang
2013-02-01 7:39 ` [PATCH V4 RESEND 17/22] virtio: introduce virtio_del_queue() Jason Wang
2013-02-01 7:39 ` [PATCH V4 RESEND 18/22] virtio: add a queue_index to VirtQueue Jason Wang
2013-02-01 7:39 ` [PATCH V4 RESEND 19/22] virtio-net: separate virtqueue from VirtIONet Jason Wang
2013-02-01 7:39 ` [PATCH V4 RESEND 20/22] virtio-net: multiqueue support Jason Wang
2013-02-01 7:39 ` [PATCH V4 RESEND 21/22] virtio-net: migration support for multiqueue Jason Wang
2013-02-01 7:39 ` [PATCH V4 RESEND 22/22] virtio-net: compat multiqueue support Jason Wang
2013-02-01 8:22 ` [PATCH V4 RESEND 00/22] Multiqueue virtio-net Jason Wang
2013-02-04 22:53 ` Anthony Liguori
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=511AB313.4060405@suse.de \
--to=afaerber@suse.de \
--cc=agraf@suse.de \
--cc=aliguori@us.ibm.com \
--cc=blauwirbel@gmail.com \
--cc=gaowanlong@cn.fujitsu.com \
--cc=jasowang@redhat.com \
--cc=jwhan@filewood.snu.ac.kr \
--cc=krkumar2@in.ibm.com \
--cc=kvm@vger.kernel.org \
--cc=mprivozn@redhat.com \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=rusty@rustcorp.com.au \
--cc=shajnocz@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox