From mboxrd@z Thu Jan  1 00:00:00 1970
From: =?ISO-8859-15?Q?Andreas_F=E4rber?= <afaerber@suse.de>
Subject: Re: [Qemu-devel] [PATCH V4 RESEND 09/22] net: multiqueue support
Date: Tue, 12 Feb 2013 22:24:35 +0100
Message-ID: <511AB313.4060405@suse.de>
References: <1359704396-55327-1-git-send-email-jasowang@redhat.com> <1359704396-55327-10-git-send-email-jasowang@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-15
Content-Transfer-Encoding: QUOTED-PRINTABLE
Cc: aliguori@us.ibm.com, mst@redhat.com, qemu-devel@nongnu.org,
	blauwirbel@gmail.com, shajnocz@redhat.com, krkumar2@in.ibm.com,
	kvm@vger.kernel.org, mprivozn@redhat.com, rusty@rustcorp.com.au,
	jwhan@filewood.snu.ac.kr, gaowanlong@cn.fujitsu.com,
	Alexander Graf <agraf@suse.de>
To: Jason Wang <jasowang@redhat.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from cantor2.suse.de ([195.135.220.15]:42701 "EHLO mx2.suse.de"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1750757Ab3BLVYn (ORCPT <rfc822;kvm@vger.kernel.org>);
	Tue, 12 Feb 2013 16:24:43 -0500
In-Reply-To: <1359704396-55327-10-git-send-email-jasowang@redhat.com>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

Am 01.02.2013 08:39, schrieb Jason Wang:
> diff --git a/net/net.c b/net/net.c
> index 98a1934..9806862 100644
> --- a/net/net.c
> +++ b/net/net.c
[...]
> @@ -271,9 +287,7 @@ static void qemu_cleanup_net_client(NetClientStat=
e *nc)
>  {
>      QTAILQ_REMOVE(&net_clients, nc, next);
> =20
> -    if (nc->info->cleanup) {
> -        nc->info->cleanup(nc);
> -    }
> +    nc->info->cleanup(nc);
>  }

This change broke qemu-system-ppc64 -M pseries.
Why was the NULL guard dropped?

Andreas

--=20
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrn=
berg