From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paolo Bonzini Subject: Re: [PATCH] x86 emulator: fix parity calculation for AAD instruction Date: Wed, 13 Feb 2013 16:57:51 +0100 Message-ID: <511BB7FF.8020307@redhat.com> References: <20130213155039.GG9817@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: kvm@vger.kernel.org, mtosatti@redhat.com To: Gleb Natapov Return-path: Received: from mx1.redhat.com ([209.132.183.28]:30426 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1759223Ab3BMP5y (ORCPT ); Wed, 13 Feb 2013 10:57:54 -0500 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r1DFvsKG010161 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Wed, 13 Feb 2013 10:57:54 -0500 In-Reply-To: <20130213155039.GG9817@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: Il 13/02/2013 16:50, Gleb Natapov ha scritto: > Reported-by: Paolo Bonzini > Suggested-by: Paolo Bonzini > Signed-off-by: Gleb Natapov > > diff --git a/arch/x86/kvm/emulate.c b/arch/x86/kvm/emulate.c > index 2b11318..a335cc6 100644 > --- a/arch/x86/kvm/emulate.c > +++ b/arch/x86/kvm/emulate.c > @@ -2995,14 +2995,11 @@ static int em_aad(struct x86_emulate_ctxt *ctxt) > > ctxt->dst.val = (ctxt->dst.val & 0xffff0000) | al; > > - ctxt->eflags &= ~(X86_EFLAGS_PF | X86_EFLAGS_SF | X86_EFLAGS_ZF); > - > - if (!al) > - ctxt->eflags |= X86_EFLAGS_ZF; > - if (!(al & 1)) > - ctxt->eflags |= X86_EFLAGS_PF; > - if (al & 0x80) > - ctxt->eflags |= X86_EFLAGS_SF; > + /* Set PF, ZF, SF */ > + ctxt->src.type = OP_IMM; > + ctxt->src.val = 0; > + ctxt->src.bytes = 1; > + fastop(ctxt, em_or); > > return X86EMUL_CONTINUE; > } > -- > Gleb. > Reviewed-by: Paolo Bonzini