From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jan Kiszka Subject: Re: [PATCH] KVM: nVMX: Fix injection of PENDING_INTERRUPT and NMI_WINDOW exits to L1 Date: Sat, 16 Feb 2013 15:55:21 +0100 Message-ID: <511F9DD9.5010001@web.de> References: <511F72B8.6060305@web.de> <511F76CB.2000405@web.de> <20130216144617.GA3253@fermat.math.technion.ac.il> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="----enig2KEQBMUOEDTSWPPUOITRP" Cc: Gleb Natapov , Marcelo Tosatti , kvm , "Nakajima, Jun" To: Nadav Har'El Return-path: Received: from mout.web.de ([212.227.15.3]:63976 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753284Ab3BPOz3 (ORCPT ); Sat, 16 Feb 2013 09:55:29 -0500 In-Reply-To: <20130216144617.GA3253@fermat.math.technion.ac.il> Sender: kvm-owner@vger.kernel.org List-ID: This is an OpenPGP/MIME signed message (RFC 4880 and 3156) ------enig2KEQBMUOEDTSWPPUOITRP Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable On 2013-02-16 15:46, Nadav Har'El wrote: > On Sat, Feb 16, 2013, Jan Kiszka wrote about "Re: [PATCH] KVM: nVMX: Fi= x injection of PENDING_INTERRUPT and NMI_WINDOW exits to L1": >> No, this is wrong. I first wrote a patch that ignored enable_irq_windo= w >> when the guest is not interested in external IRQs. But then I thought >> that wasn't correct. I tend to believe now my first idea was better. >=20 > If you want to make the !PIN_BASED_EXT_INTR_MASK case work correctly, > please also see: >=20 > https://bugzilla.kernel.org/show_bug.cgi?id=3D53711 Yes, I already realized that there is more broken. Trying to find a way to fix this ATM. That specifically means deciding when to execute vmx_complete/cancel_interrupts and when not. This patch seems correct now, just insufficient to make direct injection from L0 to L2 work. Jan ------enig2KEQBMUOEDTSWPPUOITRP Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.16 (GNU/Linux) Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iEYEARECAAYFAlEfnd0ACgkQitSsb3rl5xRnXwCgwE95wufHq/HRf8LS8BYZbtiE uwYAmQGS26wlN5EaBUo+jpsVUQ/SQWHy =SLB+ -----END PGP SIGNATURE----- ------enig2KEQBMUOEDTSWPPUOITRP--