From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?ISO-8859-1?Q?Andreas_F=E4rber?= Subject: Re: [PATCH v2 12/15] target-ppc: Refactor debug output macros Date: Mon, 25 Feb 2013 14:14:18 +0100 Message-ID: <512B63AA.7070109@suse.de> References: <1361420711-15698-1-git-send-email-afaerber@suse.de> <1361420711-15698-13-git-send-email-afaerber@suse.de> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: qemu-devel@nongnu.org, Gleb Natapov , Marcelo Tosatti , PowerPC , Overall To: Alexander Graf Return-path: Received: from cantor2.suse.de ([195.135.220.15]:47384 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757833Ab3BYNOV (ORCPT ); Mon, 25 Feb 2013 08:14:21 -0500 In-Reply-To: Sender: kvm-owner@vger.kernel.org List-ID: Am 25.02.2013 13:54, schrieb Alexander Graf: >=20 > On 21.02.2013, at 05:25, Andreas F=E4rber wrote: >=20 >> Make debug output compile-testable even if disabled. >> >> Rename dprintf() in kvm.c to kvm_dprintf() to avoid conflict with gl= ibc. >> >> Inline DEBUG_OP check in excp_helper.c. >> Inline LOG_MMU_STATE() in mmu_helper.c. >> Inline PPC_{DEBUG_SPR,DUMP_SPR_ACCESSES} checks in translate_init.c. >> >> Signed-off-by: Andreas F=E4rber >=20 > I assume you verified that all the bits do get optimized out, right? = :) No, I didn't for each, my focus was to make debug code compile and keep it compiling after my CPU changes. :) Please read up on the new discussion of rth not liking static const and proposing to go back to v1, modulo do { ... } while (0). Like I said there, if finding a solution that pleases everyone fails, then I will leave it to the maintainers (i.e., you) to choose and apply a solution or to live with the resulting breakages. Andreas >=20 > Reviewed-by: Alexander Graf >=20 >=20 > Alex >=20 --=20 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrn= berg