From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jan Kiszka Subject: Re: [PATCH v2] target-i386: Improve x86_cpu_list output Date: Wed, 27 Feb 2013 10:37:09 +0100 Message-ID: <512DD3C5.10100@siemens.com> References: <512DCEC7.3030902@siemens.com> <512DD2E4.1050605@suse.de> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Cc: Igor Mammedov , Anthony Liguori , qemu-devel , kvm , Eduardo Habkost To: =?ISO-8859-1?Q?Andreas_F=E4rber?= Return-path: In-Reply-To: <512DD2E4.1050605@suse.de> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+gceq-qemu-devel=gmane.org@nongnu.org Sender: qemu-devel-bounces+gceq-qemu-devel=gmane.org@nongnu.org List-Id: kvm.vger.kernel.org On 2013-02-27 10:33, Andreas F=E4rber wrote: > Am 27.02.2013 10:15, schrieb Jan Kiszka: >> Several issues fixed: >> - We were missing a bunch of feature lists. Fix this by simply dumpin= g >> the meta list feature_word_info. >> - kvm_enabled() cannot be true at this point because accelerators are >> initialized much later during init. Also, hiding this makes it very >> hard to discover for users. Simply dump unconditionally if CONFIG_K= VM >> is set. >> - Add explanation for "host" CPU type. >> >> Signed-off-by: Jan Kiszka >> --- >> >> Changes in v2: >> - Do not dump "host" type if CONFIG_KVM is not set >> - Explain that "host" depends on KVM mode >=20 > I had requested on v1 to not fix multiple issues in one patch, but I ca= n > split it myself on Friday if there's no other issues. Sorry, missed that. But I also see no point in splitting up in this case, specifically as we no agree on the result. Jan --=20 Siemens AG, Corporate Technology, CT RTC ITP SDP-DE Corporate Competence Center Embedded Linux