From mboxrd@z Thu Jan  1 00:00:00 1970
From: =?ISO-8859-15?Q?Andreas_F=E4rber?= <afaerber@suse.de>
Subject: Re: [Qemu-devel] [PATCH v7 03/11] target-arm: Drop CPUARMState* argument
 from bank_number()
Date: Mon, 04 Mar 2013 12:12:05 +0100
Message-ID: <51348185.6040805@suse.de>
References: <1361900421-28354-1-git-send-email-peter.maydell@linaro.org> <1361900421-28354-4-git-send-email-peter.maydell@linaro.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-15
Content-Transfer-Encoding: QUOTED-PRINTABLE
Cc: qemu-devel@nongnu.org, Gleb Natapov <gleb@redhat.com>,
	kvm@vger.kernel.org, patches@linaro.org,
	Marcelo Tosatti <mtosatti@redhat.com>,
	kvmarm@lists.cs.columbia.edu, Blue Swirl <blauwirbel@gmail.com>,
	Paolo Bonzini <pbonzini@redhat.com>
To: Peter Maydell <peter.maydell@linaro.org>
Return-path: <kvm-owner@vger.kernel.org>
Received: from cantor2.suse.de ([195.135.220.15]:38694 "EHLO mx2.suse.de"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1756919Ab3CDLMH (ORCPT <rfc822;kvm@vger.kernel.org>);
	Mon, 4 Mar 2013 06:12:07 -0500
In-Reply-To: <1361900421-28354-4-git-send-email-peter.maydell@linaro.org>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

Am 26.02.2013 18:40, schrieb Peter Maydell:
> Drop the CPUARMState* argument from bank_number(), since we only
> use it for passing to cpu_abort(). Use hw_error() instead.
> This avoids propagating further interfaces using env pointers.
>=20
> In the long term this function's callers need auditing to fix
> problems where badly behaved guests can pass invalid bank numbers.
>=20
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>

Reviewed-by: Andreas F=E4rber <afaerber@suse.de>

Thanks,
Andreas

--=20
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrn=
berg