From: "Andreas Färber" <afaerber@suse.de>
To: Sanjay Lal <sanjayl@kymasys.com>
Cc: qemu-devel@nongnu.org, Gleb Natapov <gleb@redhat.com>,
Marcelo Tosatti <mtosatti@redhat.com>,
Aurelien Jarno <aurelien@aurel32.net>,
kvm@vger.kernel.org
Subject: Re: [Qemu-devel] [PATCH 00/12] KVM Support for MIPS32 Processors
Date: Mon, 04 Mar 2013 12:55:53 +0100 [thread overview]
Message-ID: <51348BC9.9080006@suse.de> (raw)
In-Reply-To: <1362237527-23678-1-git-send-email-sanjayl@kymasys.com>
Hello,
Am 02.03.2013 16:18, schrieb Sanjay Lal:
> The following patchset implements KVM support for MIPS32 processors,
> using Trap & Emulate, with basic runtime binary translation to improve
> performance.
[snip]
Please see http://wiki.qemu.org/Contribute/SubmitAPatch for some hints
on how to improve submission of your QEMU patchset. In particular we
require Signed-off-bys just like Linux, subjects should use
"target-mips: " or similar based on file/directory names, subject line
should be one short statement and commit message should give further
explanations of what the patch is doing and why, where appropriate.
Also a fair warning: I am refactoring the core CPU code, so you should
be tracking qemu.git and/or mailing list for possible conflicts and
rebasing necessary.
In that context please prefer use of MIPSCPU over CPUMIPSState (e.g., in
GIC state and functions).
Please adopt our Coding Style, which among other things asks for
CamelCase struct naming (e.g., MIPSGICState rather than gic_t).
Please learn about QOM usage and its conventions. Your GIC should
probably be a SysBusDevice, not a pre-qdev collection of manually
allocated state.
http://wiki.qemu.org/QOMConventions
There's also an ongoing discussion about DPRINTF()s defined as no-op "do
{} while(0)" leading to format string breakages over time. Recommended
replacement is a macro using "do { if (FOO) { ... } } while (0)", with
FOO evaluating to 0 in the no-debug case, so that everything gets
compile-tested but optimized out.
Regards,
Andreas
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
prev parent reply other threads:[~2013-03-04 11:55 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-02 15:18 [Qemu-devel][PATCH 00/12] KVM Support for MIPS32 Processors Sanjay Lal
2013-03-02 15:18 ` [Qemu-devel][PATCH 01/12] KVM/MIPS: Bootcode for MIPS SMP configurations with a GCMP Sanjay Lal
2013-03-02 20:03 ` [Qemu-devel] [PATCH " Peter Maydell
2013-03-06 19:44 ` Sanjay Lal
2013-03-02 15:18 ` [Qemu-devel][PATCH 01/12] MIPS: " Sanjay Lal
2013-03-02 15:18 ` [Qemu-devel][PATCH 02/12] KVM/MIPS: GIC emulation for SMP guests Sanjay Lal
2013-03-02 15:18 ` [Qemu-devel][PATCH 03/12] KVM/MIPS: Add save/restore state APIs for saving/restoring KVM guests Sanjay Lal
2013-03-02 15:27 ` [Qemu-devel] [PATCH " Peter Maydell
2013-03-06 19:45 ` Sanjay Lal
2013-03-02 15:18 ` [Qemu-devel][PATCH 04/12] KVM/MIPS: Do not start the periodic timer in KVM mode. Compare/Count timer interrupts are handled in-kernel Sanjay Lal
2013-03-02 15:18 ` [Qemu-devel][PATCH 05/12] KVM/MIPS: In KVM mode, inject IRQ2 (I/O) interupts via ioctls(). COP0 emulation is in-kernel Sanjay Lal
2013-03-02 15:18 ` [Qemu-devel][PATCH 06/12] KVM/MIPS: Define APIs to convert Guest KSEG0 <-> Guest Physical addresses Sanjay Lal
2013-03-02 15:18 ` [Qemu-devel][PATCH 07/12] KVM/MIPS: QEMU <-> Kernel interface for KVM/MIPS Sanjay Lal
2013-03-02 15:44 ` [Qemu-devel] [PATCH " Peter Maydell
2013-03-02 15:18 ` [Qemu-devel][PATCH 08/12] KVM/MIPS: Enable KVM/MIPS for MIPS targets. Add MIPS GIC code to the build Sanjay Lal
2013-03-02 15:42 ` [Qemu-devel] [PATCH " Peter Maydell
2013-03-04 11:27 ` Andreas Färber
2013-03-02 15:18 ` [Qemu-devel][PATCH 09/12] KVM/MIPS: set sigmask length to 16 for MIPS targets Sanjay Lal
2013-03-02 15:18 ` [Qemu-devel][PATCH 10/12] KVM/MIPS: Set page size to 16K in KVM mode Sanjay Lal
2013-03-02 15:18 ` [Qemu-devel][PATCH 11/12] KVM/MIPS: MIPS specfic APIs for KVM Sanjay Lal
2013-03-02 15:45 ` [Qemu-devel] [PATCH " Peter Maydell
2013-03-06 19:43 ` Sanjay Lal
2013-03-02 15:18 ` [Qemu-devel][PATCH 12/12] KVM/MIPS: General KVM support and support for SMP Guests Sanjay Lal
2013-03-04 1:21 ` [Qemu-devel][PATCH 00/12] KVM Support for MIPS32 Processors Zhang, Yang Z
2013-03-04 11:55 ` Andreas Färber [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51348BC9.9080006@suse.de \
--to=afaerber@suse.de \
--cc=aurelien@aurel32.net \
--cc=gleb@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=mtosatti@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=sanjayl@kymasys.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox