From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?ISO-8859-15?Q?Andreas_F=E4rber?= Subject: Re: [Qemu-devel] [PATCH 00/12] KVM Support for MIPS32 Processors Date: Mon, 04 Mar 2013 12:55:53 +0100 Message-ID: <51348BC9.9080006@suse.de> References: <1362237527-23678-1-git-send-email-sanjayl@kymasys.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: qemu-devel@nongnu.org, Gleb Natapov , Marcelo Tosatti , Aurelien Jarno , kvm@vger.kernel.org To: Sanjay Lal Return-path: Received: from cantor2.suse.de ([195.135.220.15]:40907 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753027Ab3CDLz4 (ORCPT ); Mon, 4 Mar 2013 06:55:56 -0500 In-Reply-To: <1362237527-23678-1-git-send-email-sanjayl@kymasys.com> Sender: kvm-owner@vger.kernel.org List-ID: Hello, Am 02.03.2013 16:18, schrieb Sanjay Lal: > The following patchset implements KVM support for MIPS32 processors, > using Trap & Emulate, with basic runtime binary translation to improv= e > performance. [snip] Please see http://wiki.qemu.org/Contribute/SubmitAPatch for some hints on how to improve submission of your QEMU patchset. In particular we require Signed-off-bys just like Linux, subjects should use "target-mips: " or similar based on file/directory names, subject line should be one short statement and commit message should give further explanations of what the patch is doing and why, where appropriate. Also a fair warning: I am refactoring the core CPU code, so you should be tracking qemu.git and/or mailing list for possible conflicts and rebasing necessary. In that context please prefer use of MIPSCPU over CPUMIPSState (e.g., i= n GIC state and functions). Please adopt our Coding Style, which among other things asks for CamelCase struct naming (e.g., MIPSGICState rather than gic_t). Please learn about QOM usage and its conventions. Your GIC should probably be a SysBusDevice, not a pre-qdev collection of manually allocated state. http://wiki.qemu.org/QOMConventions There's also an ongoing discussion about DPRINTF()s defined as no-op "d= o {} while(0)" leading to format string breakages over time. Recommended replacement is a macro using "do { if (FOO) { ... } } while (0)", with =46OO evaluating to 0 in the no-debug case, so that everything gets compile-tested but optimized out. Regards, Andreas --=20 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrn= berg