From mboxrd@z Thu Jan  1 00:00:00 1970
From: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= <afaerber@suse.de>
Subject: Re: [Qemu-devel] [PATCH v7 07/11] hw/arm_gic: Convert ARM GIC classes
 to use init/realize
Date: Mon, 04 Mar 2013 13:04:47 +0100
Message-ID: <51348DDF.6090604@suse.de>
References: <1361900421-28354-1-git-send-email-peter.maydell@linaro.org> <1361900421-28354-8-git-send-email-peter.maydell@linaro.org> <51348131.8020703@suse.de> <CAFEAcA9ehuSRtA2aYvXTyCYA4VFv5T8zRLq4NyNCzXGSbCya-g@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: QUOTED-PRINTABLE
Cc: qemu-devel@nongnu.org, Gleb Natapov <gleb@redhat.com>,
	kvm@vger.kernel.org, patches@linaro.org,
	Marcelo Tosatti <mtosatti@redhat.com>,
	kvmarm@lists.cs.columbia.edu, Blue Swirl <blauwirbel@gmail.com>,
	Paolo Bonzini <pbonzini@redhat.com>
To: Peter Maydell <peter.maydell@linaro.org>
Return-path: <kvm-owner@vger.kernel.org>
Received: from cantor2.suse.de ([195.135.220.15]:41523 "EHLO mx2.suse.de"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1753814Ab3CDMEu (ORCPT <rfc822;kvm@vger.kernel.org>);
	Mon, 4 Mar 2013 07:04:50 -0500
In-Reply-To: <CAFEAcA9ehuSRtA2aYvXTyCYA4VFv5T8zRLq4NyNCzXGSbCya-g@mail.gmail.com>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

Am 04.03.2013 12:50, schrieb Peter Maydell:
> On 4 March 2013 19:10, Andreas F=C3=A4rber <afaerber@suse.de> wrote:
>> Am 26.02.2013 18:40, schrieb Peter Maydell:
>=20
>>>      if (s->num_cpu > NCPU) {
>>> -        hw_error("requested %u CPUs exceeds GIC maximum %d\n",
>>> -                 s->num_cpu, NCPU);
>>> +        error_setg(errp, "requested %u CPUs exceeds GIC maximum %d=
\n",
>>
>> Please drop \n for error_setg(). Probably would be worth adding to a
>> convert-to-realize section on the Wiki.
>=20
> Doh. That's such a trivial change I intend to just make it in
> passing when I put these changes into target-arm.next rather
> than sending out an entire fresh round of patches, unless you
> object.
>=20
>> Otherwise looks fine, thanks.
>=20
> Should I mark such a fixed-up patch with your reviewed-by tag?

Yes, that's fine, thanks.

Andreas

--=20
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=C3=BCrnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imend=C3=B6rffer; HRB 16746 AG N=C3=
=BCrnberg