From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paolo Bonzini Subject: Re: [PATCH uq/master 2/2] kvm: forward INIT signals coming from the chipset Date: Sun, 10 Mar 2013 16:04:39 +0100 Message-ID: <513CA107.5030602@redhat.com> References: <1362811730-6716-1-git-send-email-pbonzini@redhat.com> <1362811730-6716-3-git-send-email-pbonzini@redhat.com> <20130310115439.GN11223@redhat.com> <513C9876.6090708@redhat.com> <20130310145524.GJ24444@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: jan.kiszka@siemens.com, mtosatti@redhat.com, qemu-devel@nongnu.org, kvm@vger.kernel.org To: Gleb Natapov Return-path: Received: from mail-we0-f180.google.com ([74.125.82.180]:63671 "EHLO mail-we0-f180.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751837Ab3CJPEn (ORCPT ); Sun, 10 Mar 2013 11:04:43 -0400 Received: by mail-we0-f180.google.com with SMTP id k14so2603174wer.39 for ; Sun, 10 Mar 2013 08:04:42 -0700 (PDT) In-Reply-To: <20130310145524.GJ24444@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: Il 10/03/2013 15:55, Gleb Natapov ha scritto: > > > Why not move INIT case from below as is? Vcpu is reset to correct sate > > > by QEMU just like during system_reset. > > > > APs would not be able to receive SIPIs after executing do_cpu_init, > > because they would stay in KVM_MP_STATE_RUNNABLE state. > > If APs are in runnable state after reset with in kernel irq chip we > have a bug somewhere. Here is where we are resetting the processor. After clearing CPU_INTERRUPT_INIT, no matter what else we do (such as resetting the APIC and CPU), we need to set the mp_state to KVM_MP_STATE_INIT_RECEIVED. Or if we go with your simpler hypervisor patch, we need to go to either KVM_MP_STATE_INIT_RECEIVED for APs (wait for SIPI) or KVM_MP_STATE_SIPI_RECEIVED for the BSP (restart running from the reset vector). > Should AP be able to get SIPI without INIT after trigger of INIT# line? Yes, the effect is the same for an INIT interrupt and the triggering of INIT#. Paolo