Re: [PATCH] x86: kvm: reset the bootstrap processor when it gets an INIT

Paolo Bonzini
2013-03-10T17:19:07Z

Il 10/03/2013 16:35, Gleb Natapov ha scritto:
>> > However, it would effectively redefine the meaning of
>> > KVM_MP_STATE_INIT_RECEIVED and KVM_MP_STATE_SIPI_RECEIVED, respectively
>> > to KVM_MP_STATE_WAIT_FOR_SIPI and KVM_MP_STATE_RESETTING. I wasn't sure
>> > if this is considered an API change (personally, I would treat it as one).
>> >
> If it is kernel module internal it definitely is not API change.
> INIT/SIPI handling is a bit ad-hoc right now anyway as Jan noticed. For
> instance INIT does not really resets VCPU. Only after SIPI it is really
> reset, so KVM_MP_STATE_SIPI_RECEIVED is really KVM_MP_STATE_RESET_ME_RIGHT_NOW
> state.

Yeah, and the current definition is ambiguous (without hypervisor
patches, there's no way to use it as the names would suggest), so
perhaps the right thing to do is to rename the states (old names kept
for backwards compatibility only) and work from there.

Paolo