From mboxrd@z Thu Jan  1 00:00:00 1970
From: Paolo Bonzini <pbonzini@redhat.com>
Subject: Re: [PATCH] KVM: x86: Convert INIT and SIPI signals into synchronously
 handled events
Date: Tue, 12 Mar 2013 13:29:37 +0100
Message-ID: <513F1FB1.60101@redhat.com>
References: <513F1529.3040309@siemens.com> <513F1A63.9070107@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Cc: Jan Kiszka <jan.kiszka@siemens.com>,
	Gleb Natapov <gleb@redhat.com>,
	Marcelo Tosatti <mtosatti@redhat.com>,
	kvm <kvm@vger.kernel.org>
To: unlisted-recipients:; (no To-header on input)
Return-path: <kvm-owner@vger.kernel.org>
Received: from mail-qc0-f177.google.com ([209.85.216.177]:39845 "EHLO
	mail-qc0-f177.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1755338Ab3CLM3r (ORCPT <rfc822;kvm@vger.kernel.org>);
	Tue, 12 Mar 2013 08:29:47 -0400
Received: by mail-qc0-f177.google.com with SMTP id u28so1973835qcs.8
        for <kvm@vger.kernel.org>; Tue, 12 Mar 2013 05:29:46 -0700 (PDT)
In-Reply-To: <513F1A63.9070107@redhat.com>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

Il 12/03/2013 13:06, Paolo Bonzini ha scritto:
> > @@ -6178,7 +6177,13 @@ int kvm_arch_vcpu_ioctl_get_mpstate(struct kvm_vcpu *vcpu,
> >  int kvm_arch_vcpu_ioctl_set_mpstate(struct kvm_vcpu *vcpu,
> >  				    struct kvm_mp_state *mp_state)
> >  {
> > -	vcpu->arch.mp_state = mp_state->mp_state;
> > +	if (mp_state->mp_state == KVM_MP_STATE_SIPI_RECEIVED) {
> > +		if (!kvm_vcpu_has_lapic(vcpu))
> > +			return -EINVAL;
> > +		vcpu->arch.mp_state = KVM_MP_STATE_INIT_RECEIVED;
> > +		set_bit(KVM_APIC_SIPI, &vcpu->arch.apic->pending_events);
> > +	} else
> > +		vcpu->arch.mp_state = mp_state->mp_state;
> 
> Should INIT_RECEIVED also be invalid without an in-kernel LAPIC?

And since migration was brought up yesterday, do we need an interface to
retrieve and set this?

And should KVM_GET/SET_VCPU_EVENTS use the new sipi_vector in the APIC
rather than the old one?

Paolo