From: Paolo Bonzini <pbonzini@redhat.com>
To: Gleb Natapov <gleb@redhat.com>
Cc: Jan Kiszka <jan.kiszka@siemens.com>,
Marcelo Tosatti <mtosatti@redhat.com>, kvm <kvm@vger.kernel.org>
Subject: Re: [PATCH] KVM: x86: Convert INIT and SIPI signals into synchronously handled events
Date: Tue, 12 Mar 2013 14:43:38 +0100 [thread overview]
Message-ID: <513F310A.40700@redhat.com> (raw)
In-Reply-To: <20130312134145.GE11223@redhat.com>
Il 12/03/2013 14:41, Gleb Natapov ha scritto:
> Not sure I understand. I am saying the code should be:
>
> if (test_and_clear_bit(KVM_APIC_INIT, &apic->pending_events)) {
> vcpu->arch.mp_state = KVM_MP_STATE_INIT_RECEIVED;
> kvm_lapic_reset(vcpu);
> kvm_vcpu_reset(vcpu);
> }
> if (test_and_clear_bit(KVM_APIC_SIPI, &apic->pending_events) &&
> vcpu->arch.mp_state == KVM_MP_STATE_INIT_RECEIVED) {
> vcpu->arch.sipi_vector = apic->sipi_vector;
> }
>
Yes, this is also discussed in the async_pf thread. But kvm_vcpu_reset
is what sets CS based on the sipi_vector, so some more changes are
needed (or you can just reset the VCPU twice, but that's ugly...).
Paolo
next prev parent reply other threads:[~2013-03-12 13:43 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-12 11:44 [PATCH] KVM: x86: Convert INIT and SIPI signals into synchronously handled events Jan Kiszka
2013-03-12 12:06 ` Paolo Bonzini
2013-03-12 12:29 ` Gleb Natapov
2013-03-12 12:29 ` Paolo Bonzini
2013-03-12 12:46 ` Jan Kiszka
2013-03-12 12:49 ` Gleb Natapov
2013-03-12 12:52 ` Jan Kiszka
2013-03-12 12:53 ` Gleb Natapov
2013-03-12 13:09 ` Paolo Bonzini
2013-03-12 13:13 ` Jan Kiszka
2013-03-12 12:58 ` Jan Kiszka
2013-03-12 13:01 ` Jan Kiszka
2013-03-12 13:13 ` Paolo Bonzini
2013-03-12 13:16 ` Jan Kiszka
2013-03-12 13:25 ` Gleb Natapov
2013-03-12 13:27 ` Jan Kiszka
2013-03-12 13:37 ` Gleb Natapov
2013-03-13 7:39 ` Jan Kiszka
2013-03-13 9:03 ` Paolo Bonzini
2013-03-13 9:08 ` Jan Kiszka
2013-03-12 13:12 ` Gleb Natapov
2013-03-12 13:21 ` Jan Kiszka
2013-03-12 13:41 ` Gleb Natapov
2013-03-12 13:43 ` Paolo Bonzini [this message]
2013-03-12 13:52 ` Gleb Natapov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=513F310A.40700@redhat.com \
--to=pbonzini@redhat.com \
--cc=gleb@redhat.com \
--cc=jan.kiszka@siemens.com \
--cc=kvm@vger.kernel.org \
--cc=mtosatti@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox