From mboxrd@z Thu Jan 1 00:00:00 1970 From: Xiao Guangrong Subject: Re: [PATCH 1/2] KVM: MMU: Mark sp mmio cached when creating mmio spte Date: Wed, 13 Mar 2013 13:06:23 +0800 Message-ID: <5140094F.5080700@linux.vnet.ibm.com> References: <20130312174333.7f76148e.yoshikawa_takuya_b1@lab.ntt.co.jp> <20130312174440.5d5199ee.yoshikawa_takuya_b1@lab.ntt.co.jp> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Cc: mtosatti@redhat.com, gleb@redhat.com, kvm@vger.kernel.org To: Takuya Yoshikawa Return-path: Received: from e28smtp07.in.ibm.com ([122.248.162.7]:36643 "EHLO e28smtp07.in.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750932Ab3CMFGd (ORCPT ); Wed, 13 Mar 2013 01:06:33 -0400 Received: from /spool/local by e28smtp07.in.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Wed, 13 Mar 2013 10:32:59 +0530 Received: from d28relay04.in.ibm.com (d28relay04.in.ibm.com [9.184.220.61]) by d28dlp03.in.ibm.com (Postfix) with ESMTP id 725511258051 for ; Wed, 13 Mar 2013 10:37:30 +0530 (IST) Received: from d28av01.in.ibm.com (d28av01.in.ibm.com [9.184.220.63]) by d28relay04.in.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id r2D56Na527852910 for ; Wed, 13 Mar 2013 10:36:23 +0530 Received: from d28av01.in.ibm.com (loopback [127.0.0.1]) by d28av01.in.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id r2D56P9t013657 for ; Wed, 13 Mar 2013 05:06:25 GMT In-Reply-To: <20130312174440.5d5199ee.yoshikawa_takuya_b1@lab.ntt.co.jp> Sender: kvm-owner@vger.kernel.org List-ID: On 03/12/2013 04:44 PM, Takuya Yoshikawa wrote: > This will be used not to zap unrelated mmu pages when creating/moving > a memory slot later. How about save all mmio spte into a mmio-rmap? The good things are: - instead walking all shadow page, we can only walk the rmap - Comparing to zap a shadow page, it does not need to flush TLB after zapping mmio sptes