From mboxrd@z Thu Jan 1 00:00:00 1970 From: Xiao Guangrong Subject: Re: [PATCH 1/5] Revert "KVM: x86: Optimize mmio spte zapping when, creating/moving memslot" Date: Mon, 18 Mar 2013 15:36:53 +0800 Message-ID: <5146C415.7010401@linux.vnet.ibm.com> References: <51433D98.4050605@linux.vnet.ibm.com> <51433DC3.1070404@linux.vnet.ibm.com> <20130316110747.57fb20e01bcfd890125e2c81@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Cc: Marcelo Tosatti , Gleb Natapov , LKML , KVM To: Takuya Yoshikawa Return-path: In-Reply-To: <20130316110747.57fb20e01bcfd890125e2c81@gmail.com> Sender: linux-kernel-owner@vger.kernel.org List-Id: kvm.vger.kernel.org On 03/16/2013 10:07 AM, Takuya Yoshikawa wrote: > On Fri, 15 Mar 2013 23:26:59 +0800 > Xiao Guangrong wrote: > >> diff --git a/arch/x86/kvm/x86.c b/arch/x86/kvm/x86.c >> index d3c4787..61a5bb6 100644 >> --- a/arch/x86/kvm/x86.c >> +++ b/arch/x86/kvm/x86.c >> @@ -6991,7 +6991,7 @@ void kvm_arch_commit_memory_region(struct kvm *kvm, >> * mmio sptes. >> */ >> if ((change == KVM_MR_CREATE) || (change == KVM_MR_MOVE)) { >> - kvm_mmu_zap_mmio_sptes(kvm); >> > > ??? > + kvm_mmu_zap_all() Ouch, this is a stupid copy-paste error. It looks like that i should use git send-mail. Thank you for pointing this out, Takuya!