From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paolo Bonzini Subject: Re: [PATCH 4/5] KVM: MMU: store generation-number into mmio spte Date: Mon, 18 Mar 2013 12:19:12 +0100 Message-ID: <5146F830.1070602@redhat.com> References: <51433D98.4050605@linux.vnet.ibm.com> <51433E43.60900@linux.vnet.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Cc: Marcelo Tosatti , Gleb Natapov , LKML , KVM To: Xiao Guangrong Return-path: In-Reply-To: <51433E43.60900@linux.vnet.ibm.com> Sender: linux-kernel-owner@vger.kernel.org List-Id: kvm.vger.kernel.org Il 15/03/2013 16:29, Xiao Guangrong ha scritto: > +/* > + * spte bits of bit 3 ~ bit 11 are used as low 9 bits of > + * generation, the bits of bits 52 ~ bit 61 are used as > + * high 12 bits of generation. > + */ High 10 bits. How often does the generation number change? Especially with Takuya's patches, using just 10 bits for the generation might be enough and simplifies the code. Paolo