From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?ISO-8859-1?Q?Andreas_F=E4rber?= Subject: Re: [Qemu-devel] [PATCH v2] target-i386: Improve x86_cpu_list output Date: Sun, 24 Mar 2013 18:38:22 +0100 Message-ID: <514F3A0E.8080800@suse.de> References: <512DCEC7.3030902@siemens.com> <512DD2E4.1050605@suse.de> <512DD3C5.10100@siemens.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: Igor Mammedov , Anthony Liguori , qemu-devel , kvm , Eduardo Habkost To: Jan Kiszka Return-path: Received: from cantor2.suse.de ([195.135.220.15]:43064 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752774Ab3CXRlA (ORCPT ); Sun, 24 Mar 2013 13:41:00 -0400 In-Reply-To: <512DD3C5.10100@siemens.com> Sender: kvm-owner@vger.kernel.org List-ID: Am 27.02.2013 10:37, schrieb Jan Kiszka: > On 2013-02-27 10:33, Andreas F=E4rber wrote: >> Am 27.02.2013 10:15, schrieb Jan Kiszka: >>> Several issues fixed: >>> - We were missing a bunch of feature lists. Fix this by simply dum= ping >>> the meta list feature_word_info. >>> - kvm_enabled() cannot be true at this point because accelerators = are >>> initialized much later during init. Also, hiding this makes it v= ery >>> hard to discover for users. Simply dump unconditionally if CONFI= G_KVM >>> is set. >>> - Add explanation for "host" CPU type. >>> >>> Signed-off-by: Jan Kiszka >>> --- >>> >>> Changes in v2: >>> - Do not dump "host" type if CONFIG_KVM is not set >>> - Explain that "host" depends on KVM mode >> >> I had requested on v1 to not fix multiple issues in one patch, but I= can >> split it myself on Friday if there's no other issues. >=20 > Sorry, missed that. But I also see no point in splitting up in this > case, specifically as we no agree on the result. Thanks, applied to qom-cpu as two patches (clean git-checkout -p split)= : https://github.com/afaerber/qemu-cpu/commits/qom-cpu Sorry for taking so long. Andreas --=20 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrn= berg