From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paolo Bonzini Subject: Re: [PATCH v6 4/6] KVM: Add reset/restore rtc_status support Date: Tue, 26 Mar 2013 15:04:57 +0100 Message-ID: <5151AB09.9090701@redhat.com> References: <1363929845-29005-1-git-send-email-yang.z.zhang@intel.com> <1363929845-29005-5-git-send-email-yang.z.zhang@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: kvm@vger.kernel.org, gleb@redhat.com, mtosatti@redhat.com, xiantao.zhang@intel.com To: Yang Zhang Return-path: Received: from mail-ea0-f181.google.com ([209.85.215.181]:62503 "EHLO mail-ea0-f181.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933132Ab3CZOFD (ORCPT ); Tue, 26 Mar 2013 10:05:03 -0400 Received: by mail-ea0-f181.google.com with SMTP id z10so2956867ead.40 for ; Tue, 26 Mar 2013 07:05:01 -0700 (PDT) In-Reply-To: <1363929845-29005-5-git-send-email-yang.z.zhang@intel.com> Sender: kvm-owner@vger.kernel.org List-ID: Il 22/03/2013 06:24, Yang Zhang ha scritto: > +static void rtc_irq_restore(struct kvm_ioapic *ioapic) > +{ > + struct kvm_vcpu *vcpu; > + int vector, i, pending_eoi = 0; > + > + if (RTC_GSI != 8) Please set it to -1U if not x86, and do if (RTC_GSI >= IOAPIC_NUM_PINS) return; here. Paolo > + return; > +