From: Paolo Bonzini <pbonzini@redhat.com>
To: Yang Zhang <yang.z.zhang@intel.com>
Cc: kvm@vger.kernel.org, gleb@redhat.com, mtosatti@redhat.com,
xiantao.zhang@intel.com
Subject: Re: [PATCH v6 6/6] KVM: Use eoi to track RTC interrupt delivery status
Date: Tue, 26 Mar 2013 15:14:54 +0100 [thread overview]
Message-ID: <5151AD5E.9050303@redhat.com> (raw)
In-Reply-To: <1363929845-29005-7-git-send-email-yang.z.zhang@intel.com>
Il 22/03/2013 06:24, Yang Zhang ha scritto:
> +static void rtc_irq_ack_eoi(struct kvm_vcpu *vcpu,
> + struct rtc_status *rtc_status, int irq)
> +{
> + if (irq != RTC_GSI)
> + return;
> +
> + if (test_and_clear_bit(vcpu->vcpu_id, rtc_status->dest_map))
> + --rtc_status->pending_eoi;
> +
> + WARN_ON(rtc_status->pending_eoi < 0);
> +}
This is the only case where you're passing the struct rtc_status instead
of the struct kvm_ioapic. Please use the latter, and make it the first
argument.
> @@ -244,7 +268,14 @@ static int ioapic_deliver(struct kvm_ioapic *ioapic, int irq)
> irqe.level = 1;
> irqe.shorthand = 0;
>
> - return kvm_irq_delivery_to_apic(ioapic->kvm, NULL, &irqe, NULL);
> + if (irq == RTC_GSI) {
> + ret = kvm_irq_delivery_to_apic(ioapic->kvm, NULL, &irqe,
> + ioapic->rtc_status.dest_map);
> + ioapic->rtc_status.pending_eoi = ret;
I think you should either add a
BUG_ON(ioapic->rtc_status.pending_eoi != 0);
or use "ioapic->rtc_status.pending_eoi += ret" (or both).
> + } else
> + ret = kvm_irq_delivery_to_apic(ioapic->kvm, NULL, &irqe, NULL);
> +
> + return ret;
> }
Paolo
next prev parent reply other threads:[~2013-03-26 14:15 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-22 5:23 [PATCH v6 0/6] Use eoi to track RTC interrupt delivery status Yang Zhang
2013-03-22 5:24 ` [PATCH v6 1/6] KVM: Add vcpu info to ioapic_update_eoi() Yang Zhang
2013-03-22 5:24 ` [PATCH v6 2/6] KVM: Introduce struct rtc_status Yang Zhang
2013-03-22 5:24 ` [PATCH v6 3/6] KVM : Return destination vcpu on interrupt injection Yang Zhang
2013-03-22 7:05 ` Gleb Natapov
2013-03-22 7:50 ` Zhang, Yang Z
2013-03-22 7:57 ` Gleb Natapov
2013-03-22 5:24 ` [PATCH v6 4/6] KVM: Add reset/restore rtc_status support Yang Zhang
2013-03-26 14:04 ` Paolo Bonzini
2013-03-29 3:17 ` Zhang, Yang Z
2013-03-26 14:09 ` Paolo Bonzini
2013-03-29 3:19 ` Zhang, Yang Z
2013-03-22 5:24 ` [PATCH v6 5/6] KVM : Force vmexit with virtual interrupt delivery Yang Zhang
2013-03-22 5:24 ` [PATCH v6 6/6] KVM: Use eoi to track RTC interrupt delivery status Yang Zhang
2013-03-22 7:50 ` Gleb Natapov
2013-03-22 8:05 ` Zhang, Yang Z
2013-03-22 8:14 ` Gleb Natapov
2013-03-22 8:25 ` Zhang, Yang Z
2013-03-22 8:30 ` Gleb Natapov
2013-03-22 8:37 ` Zhang, Yang Z
2013-03-22 8:44 ` Gleb Natapov
2013-03-22 8:51 ` Zhang, Yang Z
2013-03-22 8:54 ` Gleb Natapov
2013-03-22 10:50 ` Zhang, Yang Z
2013-03-24 9:20 ` Gleb Natapov
2013-03-26 14:26 ` Paolo Bonzini
2013-03-26 14:14 ` Paolo Bonzini [this message]
2013-03-29 3:25 ` Zhang, Yang Z
2013-03-29 8:35 ` Paolo Bonzini
2013-03-29 8:42 ` Zhang, Yang Z
2013-04-02 13:08 ` Gleb Natapov
2013-04-03 0:21 ` Zhang, Yang Z
2013-04-03 4:03 ` Gleb Natapov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5151AD5E.9050303@redhat.com \
--to=pbonzini@redhat.com \
--cc=gleb@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=mtosatti@redhat.com \
--cc=xiantao.zhang@intel.com \
--cc=yang.z.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox