From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paolo Bonzini Subject: Re: [PATCH 4/4] pci: add pci test device Date: Wed, 03 Apr 2013 12:34:24 +0200 Message-ID: <515C05B0.2000401@redhat.com> References: <515BF657.7000904@redhat.com> <20130403094529.GA18179@redhat.com> <515BFC37.4000802@redhat.com> <20130403102229.GD18179@redhat.com> <515C037E.5030706@redhat.com> <20130403103301.GG18179@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: qemu-devel@nongnu.org, kvm@vger.kernel.org, gleb@redhat.com, mtosatti@redhat.com To: "Michael S. Tsirkin" Return-path: Received: from mx1.redhat.com ([209.132.183.28]:17556 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757322Ab3DCKea (ORCPT ); Wed, 3 Apr 2013 06:34:30 -0400 In-Reply-To: <20130403103301.GG18179@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: Il 03/04/2013 12:33, Michael S. Tsirkin ha scritto: > > Because someone wasn't looking. :) The hw/ reorganization patches I've > > posted fix that. > > Still not sure how to merge this, if it goes in through my tree > and that's the only comment, I'll just fix it silently ... Indeed. In fact, considering my hw/ reorganization patches will be committed soon, please put it in hw/pci (matching hw/isa/pc-testdev.c). Another comment is that you should add a description in docs/specs. Paolo