From: Paolo Bonzini <pbonzini@redhat.com>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: qemu-devel@nongnu.org, kvm@vger.kernel.org, gleb@redhat.com,
mtosatti@redhat.com
Subject: Re: [PATCH 4/4] pci: add pci test device
Date: Wed, 03 Apr 2013 16:08:45 +0200 [thread overview]
Message-ID: <515C37ED.1070104@redhat.com> (raw)
In-Reply-To: <20130403140648.GC22200@redhat.com>
Il 03/04/2013 16:06, Michael S. Tsirkin ha scritto:
> > Ok, I'll add hw/pci/bridge, and remove the "host-" prefix for host PCI
> > devices.
>
> That's too much nesting I think. hw/bridge/ and we can put isa bridges there
> as well then.
You need to group similar devices for the nesting to be useful. For
example, it should be easy to check if something is true of all ISA
bridges, or to do the same change in all of them. ISA and PCI bridges
have too little in common for that (and why not put I2C and SPI in
hw/bridge too :)).
Paolo
next prev parent reply other threads:[~2013-04-03 14:08 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-03 8:59 [PATCH 0/4] kvm-unittests: add pci PORT IO and MMIO speed tests Michael S. Tsirkin
2013-04-03 8:59 ` [PATCH 1/4] kvm: remove unused APIs Michael S. Tsirkin
2013-04-03 8:59 ` [PATCH 2/4] kvm: support any size for pio eventfd Michael S. Tsirkin
2013-04-03 8:59 ` [PATCH 3/4] kvm: support non datamatch ioeventfd Michael S. Tsirkin
2013-04-03 8:59 ` [PATCH 4/4] pci: add pci test device Michael S. Tsirkin
2013-04-03 9:28 ` Paolo Bonzini
2013-04-03 9:45 ` Michael S. Tsirkin
2013-04-03 9:53 ` Paolo Bonzini
2013-04-03 10:22 ` Michael S. Tsirkin
2013-04-03 10:25 ` Paolo Bonzini
2013-04-03 10:33 ` Michael S. Tsirkin
2013-04-03 10:34 ` Paolo Bonzini
2013-04-03 10:38 ` Michael S. Tsirkin
2013-04-03 11:48 ` Paolo Bonzini
2013-04-03 12:00 ` Michael S. Tsirkin
2013-04-03 12:05 ` Paolo Bonzini
2013-04-03 14:06 ` Michael S. Tsirkin
2013-04-03 14:08 ` Paolo Bonzini [this message]
2013-04-03 14:28 ` Michael S. Tsirkin
2013-04-03 15:46 ` Paolo Bonzini
2013-04-03 17:04 ` Michael S. Tsirkin
2013-04-03 17:10 ` Paolo Bonzini
2013-04-03 14:33 ` Michael S. Tsirkin
2013-04-03 15:09 ` Michael S. Tsirkin
2013-04-03 15:43 ` Paolo Bonzini
2013-04-03 18:39 ` Michael S. Tsirkin
2013-04-03 19:59 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=515C37ED.1070104@redhat.com \
--to=pbonzini@redhat.com \
--cc=gleb@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=mst@redhat.com \
--cc=mtosatti@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox