From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sasha Levin Subject: Re: virtio-net mq vq initialization Date: Sun, 14 Apr 2013 11:59:42 -0400 Message-ID: <516AD26E.8030205@oracle.com> References: <1365698186-27355-1-git-send-email-will.deacon@arm.com> <516716B8.9090408@oracle.com> <874nfc9e1r.fsf@rustcorp.com.au> <5169CCDD.4070205@oracle.com> <20130414100156.GB2548@redhat.com> <516AC85E.7070603@oracle.com> <20130414155342.GA7165@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: Rusty Russell , Will Deacon , kvm@vger.kernel.org, penberg@kernel.org, marc.zyngier@arm.com To: "Michael S. Tsirkin" Return-path: Received: from userp1040.oracle.com ([156.151.31.81]:41165 "EHLO userp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751877Ab3DNQAX (ORCPT ); Sun, 14 Apr 2013 12:00:23 -0400 In-Reply-To: <20130414155342.GA7165@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On 04/14/2013 11:53 AM, Michael S. Tsirkin wrote: >> >=20 >> > Initializing them only when they're actually needed will do the tr= ick here. > Not initializing, adding the buffers. In the current spec, initializa= tion > is always done before DRIVER_OK. Yeah, that's better, but we're going to need a spec change either way s= ince even adding the buffers is specifically stated to happen before DRIVER_OK: """ 6. The receive virtqueues should be filled with receive buffers. This = is described in detail below in =93Setting Up Receive Buffers=94. """ Thanks, Sasha