From: Paolo Bonzini <pbonzini@redhat.com>
To: Jan Kiszka <jan.kiszka@web.de>
Cc: Gleb Natapov <gleb@redhat.com>,
Marcelo Tosatti <mtosatti@redhat.com>, kvm <kvm@vger.kernel.org>,
"Nadav Har'El" <nyh@math.technion.ac.il>
Subject: Re: [PATCH 2/2] KVM: nVMX: VM_ENTRY/EXIT_LOAD_IA32_EFER overrides EFER.LMA settings
Date: Mon, 15 Apr 2013 13:09:30 +0200 [thread overview]
Message-ID: <516BDFEA.4040006@redhat.com> (raw)
In-Reply-To: <516A88A6.9050806@web.de>
Il 14/04/2013 12:44, Jan Kiszka ha scritto:
> From: Jan Kiszka <jan.kiszka@siemens.com>
>
> If we load the complete EFER MSR on entry or exit, EFER.LMA (and LME)
> loading is skipped. Their consistency is already checked now before
> starting the transition.
>
> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
> ---
> arch/x86/kvm/vmx.c | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/x86/kvm/vmx.c b/arch/x86/kvm/vmx.c
> index 0d13b29..1df3b6f 100644
> --- a/arch/x86/kvm/vmx.c
> +++ b/arch/x86/kvm/vmx.c
> @@ -7135,7 +7135,7 @@ static void prepare_vmcs02(struct kvm_vcpu *vcpu, struct vmcs12 *vmcs12)
>
> if (vmcs12->vm_entry_controls & VM_ENTRY_LOAD_IA32_EFER)
> vcpu->arch.efer = vmcs12->guest_ia32_efer;
> - if (vmcs12->vm_entry_controls & VM_ENTRY_IA32E_MODE)
> + else if (vmcs12->vm_entry_controls & VM_ENTRY_IA32E_MODE)
> vcpu->arch.efer |= (EFER_LMA | EFER_LME);
> else
> vcpu->arch.efer &= ~(EFER_LMA | EFER_LME);
> @@ -7536,7 +7536,7 @@ static void load_vmcs12_host_state(struct kvm_vcpu *vcpu,
> {
> if (vmcs12->vm_exit_controls & VM_EXIT_LOAD_IA32_EFER)
> vcpu->arch.efer = vmcs12->host_ia32_efer;
> - if (vmcs12->vm_exit_controls & VM_EXIT_HOST_ADDR_SPACE_SIZE)
> + else if (vmcs12->vm_exit_controls & VM_EXIT_HOST_ADDR_SPACE_SIZE)
> vcpu->arch.efer |= (EFER_LMA | EFER_LME);
> else
> vcpu->arch.efer &= ~(EFER_LMA | EFER_LME);
>
Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>
next prev parent reply other threads:[~2013-04-15 11:09 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-14 10:44 [PATCH 1/2] KVM: nVMX: Validate EFER values for VM_ENTRY/EXIT_LOAD_IA32_EFER Jan Kiszka
2013-04-14 10:44 ` [PATCH 2/2] KVM: nVMX: VM_ENTRY/EXIT_LOAD_IA32_EFER overrides EFER.LMA settings Jan Kiszka
2013-04-15 11:09 ` Paolo Bonzini [this message]
2013-04-15 11:08 ` [PATCH 1/2] KVM: nVMX: Validate EFER values for VM_ENTRY/EXIT_LOAD_IA32_EFER Paolo Bonzini
2013-04-17 22:39 ` Marcelo Tosatti
2013-04-20 8:52 ` [PATCH v2 " Jan Kiszka
2013-04-22 8:51 ` Paolo Bonzini
2013-04-22 9:54 ` [PATCH " Gleb Natapov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=516BDFEA.4040006@redhat.com \
--to=pbonzini@redhat.com \
--cc=gleb@redhat.com \
--cc=jan.kiszka@web.de \
--cc=kvm@vger.kernel.org \
--cc=mtosatti@redhat.com \
--cc=nyh@math.technion.ac.il \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox