From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paolo Bonzini Subject: Re: [PATCH 2/7] KVM: Introduce __KVM_HAVE_IRQCHIP Date: Wed, 17 Apr 2013 14:06:11 +0200 Message-ID: <516E9033.2030904@redhat.com> References: <1366133175-23986-1-git-send-email-agraf@suse.de> <1366133175-23986-3-git-send-email-agraf@suse.de> <516E8C49.2040304@redhat.com> <516E8D72.7020907@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: kvm-ppc@vger.kernel.org, "kvm@vger.kernel.org mailing list" , Scott Wood , Marcelo Tosatti , Gleb Natapov To: Alexander Graf Return-path: In-Reply-To: Sender: kvm-ppc-owner@vger.kernel.org List-Id: kvm.vger.kernel.org Il 17/04/2013 13:59, Alexander Graf ha scritto: >> > Well, we just got a patch to make it at least compile, > That was really just Yang (blindly?) fixing an issue I pointed out on > ARM. There is no kvm user space support for IA64. The kernel side has > been KConfig depending on BROKEN for a year already: Yes, I know. Still, __KVM_HAVE_IRQCHIP is clearly a subset of __KVM_HAVE_IOAPIC; defining one without the other makes no sense and will cause compilation or link errors for trace_kvm_ack_irq. Either we drop it altogether, or we should not break compilation consciously---especially if the problem is so trivial and obvious that you had to think of leaving it out. Paolo > commit a6bb7929677aacfce3f864c3cdacaa7d527945d5 > Author: Avi Kivity > Date: Thu May 17 13:14:08 2012 +0300 > > KVM: ia64: Mark ia64 KVM as BROKEN > > Practically all patches to ia64 KVM are build fixes; numerous warnings remain; > the last patch from the maintainer was committed more than three years ago. It > is clear that no one is using this thing. > > Mark as BROKEN to ensure people don't get hit by pointless build problems. > > Signed-off-by: Avi Kivity > Signed-off-by: Marcelo Tosatti > Signed-off-by: Avi Kivity