Re: [PATCH] KVM: Allow userspace to specify memory to be used for private regions.

[Paolo Bonzini <pbonzini@redhat.com>]

Il 17/04/2013 17:19, Andrew Honig ha scritto:
> Freeing the memory in kvm_arch_free_memslot is as good as anywhere
> else in KVM.  The problem is that this memory is in the user space
> process mm.  This codepath could be called after the mm is destroyed
> in the case of an process exit without closing the fd, which will
> result in a panic on vm_munmap when it tries to access the mm.

I think that's not a problem, the KVM file descriptor keeps the mm alive.

> There's also the possibility that another process closes the fd and
> messing with that processes memory map seems like it's asking for
> trouble.

You can check that current->mm == kvm->mm and leak the memory if they
don't match.

Paolo