From: Paolo Bonzini <pbonzini@redhat.com>
To: Abel Gordon <ABELG@il.ibm.com>
Cc: Gleb Natapov <gleb@redhat.com>,
dongxiao.xu@intel.com, jun.nakajima@intel.com,
kvm@vger.kernel.org, nadav@harel.org.il, owasserm@redhat.com
Subject: Re: [PATCH 09/10] KVM: nVMX: Synchronize VMCS12 content with the shadow vmcs
Date: Wed, 17 Apr 2013 23:59:48 +0200 [thread overview]
Message-ID: <516F1B54.4040801@redhat.com> (raw)
In-Reply-To: <OF86232578.3815145D-ONC2257B50.0056FE9B-C2257B50.00583076@il.ibm.com>
Il 17/04/2013 18:03, Abel Gordon ha scritto:
>> > Right, not a big deal if this is the only case when it happens. When we
>> > discussed accessors vs sync_shadow_vmcs flag approach I said that flag
>> > will work only if no vmcs12 fields are changed not as part of vmexit or
>> > vmwrite emulations. This one is such a field unfortunately. Hope it is
>> > the only one.
> Yep, remember that. I answered that L0 should NOT change VMCS12 fields
> if L1 is running and L1 didn't execute any vmlaunch, vmresume, vmwrite...
> (any vmx instruction. Sorry if I wasn't clear).
> nested_vmx_failValid is called ONLY when L1 executes vmx instructions
> which L0 traps and emulate.
>
> So, can we keep this part of the code as is ?
I think so. Not shadowing the field is just as good a solution as
forcing the copy.
Perhaps at the top of the field lists you can replace the comment about
VM_INSTRUCTION_ERROR with one that is more generic, and mentions that
fields that are changed as part of vmexit or vmwrite emulation must not
be shadowed, or alternatively *insert explanation here*...
Paolo
next prev parent reply other threads:[~2013-04-17 21:59 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-17 11:50 [PATCH 0/10] KVM: nVMX: shadow VMCS support, v2 Abel Gordon
2013-04-17 11:51 ` [PATCH 01/10] KVM: nVMX: Shadow-vmcs control fields/bits Abel Gordon
2013-04-17 11:51 ` [PATCH 02/10] KVM: nVMX: Detect shadow-vmcs capability Abel Gordon
2013-04-17 13:51 ` Gleb Natapov
2013-04-17 14:33 ` Abel Gordon
2013-04-17 11:52 ` [PATCH 03/10] KVM: nVMX: Introduce vmread and vmwrite bitmaps Abel Gordon
2013-04-17 11:52 ` [PATCH 04/10] KVM: nVMX: Refactor handle_vmwrite Abel Gordon
2013-04-17 11:53 ` [PATCH 05/10] KVM: nVMX: Allocate shadow vmcs Abel Gordon
2013-04-17 14:10 ` Gleb Natapov
2013-04-17 14:41 ` Abel Gordon
2013-04-17 14:44 ` Gleb Natapov
2013-04-17 11:53 ` [PATCH 06/10] KVM: nVMX: Release " Abel Gordon
2013-04-17 11:54 ` [PATCH 07/10] KVM: nVMX: Copy processor-specific shadow-vmcs to VMCS12 Abel Gordon
2013-04-17 11:54 ` [PATCH 08/10] KVM: nVMX: Copy VMCS12 to processor-specific shadow vmcs Abel Gordon
2013-04-17 11:55 ` [PATCH 09/10] KVM: nVMX: Synchronize VMCS12 content with the " Abel Gordon
2013-04-17 14:34 ` Gleb Natapov
2013-04-17 14:59 ` Abel Gordon
2013-04-17 15:39 ` Gleb Natapov
2013-04-17 16:03 ` Abel Gordon
2013-04-17 21:59 ` Paolo Bonzini [this message]
2013-04-18 6:24 ` Abel Gordon
2013-04-18 6:54 ` Gleb Natapov
2013-04-18 6:59 ` Paolo Bonzini
2013-04-17 11:55 ` [PATCH 10/10] KVM: nVMX: Enable and disable shadow vmcs functionality Abel Gordon
2013-04-17 14:41 ` Gleb Natapov
2013-04-17 15:18 ` Abel Gordon
2013-04-17 15:20 ` Gleb Natapov
-- strict thread matches above, loose matches on Subject: below --
2013-04-17 17:05 [PATCH 0/10] KVM: nVMX: shadow VMCS support, v3 Abel Gordon
2013-04-17 17:09 ` [PATCH 09/10] KVM: nVMX: Synchronize VMCS12 content with the shadow vmcs Abel Gordon
2013-04-18 6:41 ` Gleb Natapov
2013-04-18 7:07 ` Abel Gordon
2013-04-18 7:10 ` Gleb Natapov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=516F1B54.4040801@redhat.com \
--to=pbonzini@redhat.com \
--cc=ABELG@il.ibm.com \
--cc=dongxiao.xu@intel.com \
--cc=gleb@redhat.com \
--cc=jun.nakajima@intel.com \
--cc=kvm@vger.kernel.org \
--cc=nadav@harel.org.il \
--cc=owasserm@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox