From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marc Zyngier Subject: Re: [PATCH v3 29/32] arm64: KVM: 32bit guest fault injection Date: Wed, 24 Apr 2013 14:46:44 +0100 Message-ID: <5177E244.9000404@arm.com> References: <1365437854-30214-1-git-send-email-marc.zyngier@arm.com> <1365437854-30214-30-git-send-email-marc.zyngier@arm.com> <20130423230214.GM20569@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=WINDOWS-1252 Content-Transfer-Encoding: 8BIT Cc: "linux-arm-kernel@lists.infradead.org" , "kvmarm@lists.cs.columbia.edu" , "kvm@vger.kernel.org" , Catalin Marinas , Will Deacon , Christopher Covington To: Christoffer Dall Return-path: Received: from service87.mimecast.com ([91.220.42.44]:42127 "EHLO service87.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754955Ab3DXNqr convert rfc822-to-8bit (ORCPT ); Wed, 24 Apr 2013 09:46:47 -0400 In-Reply-To: <20130423230214.GM20569@gmail.com> Sender: kvm-owner@vger.kernel.org List-ID: On 24/04/13 00:02, Christoffer Dall wrote: > On Mon, Apr 08, 2013 at 05:17:31PM +0100, Marc Zyngier wrote: >> Add fault injection capability for 32bit guests. > > looks ok, but seems we are duplicating some functionality here, but I > realize it may not be that easy to share due to different define names > for things like PSR_X_BIT... Did you look further into this? I did, but as you noticed, the namespaces are different. We could probably define a set of KVM_AARCH32_* symbols, but I'm not sure it would be any nicer though. M. -- Jazz is not dead. It just smells funny...