From mboxrd@z Thu Jan 1 00:00:00 1970 From: "tiejun.chen" Subject: Re: [PATCH 5/7 v3] KVM: PPC: exit to user space on "ehpriv" instruction Date: Fri, 26 Apr 2013 18:56:32 +0800 Message-ID: <517A5D60.2020403@windriver.com> References: <1365417138-8202-1-git-send-email-Bharat.Bhushan@freescale.com> <1365417138-8202-2-git-send-email-Bharat.Bhushan@freescale.com> <1365417138-8202-3-git-send-email-Bharat.Bhushan@freescale.com> <1365417138-8202-4-git-send-email-Bharat.Bhushan@freescale.com> <1365417138-8202-5-git-send-email-Bharat.Bhushan@freescale.com> <1365417138-8202-6-git-send-email-Bharat.Bhushan@freescale.com> <479D519D-B8C0-406F-9BA1-B4B0EB14CB54@suse.de> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit Cc: Bharat Bhushan , , , , Bharat Bhushan To: Alexander Graf Return-path: In-Reply-To: <479D519D-B8C0-406F-9BA1-B4B0EB14CB54@suse.de> Sender: kvm-ppc-owner@vger.kernel.org List-Id: kvm.vger.kernel.org On 04/26/2013 06:45 PM, Alexander Graf wrote: > > On 08.04.2013, at 12:32, Bharat Bhushan wrote: > >> From: Bharat Bhushan >> >> "ehpriv" instruction is used for setting software breakpoints >> by user space. This patch adds support to exit to user space >> with "run->debug" have relevant information. >> >> Signed-off-by: Bharat Bhushan >> --- >> arch/powerpc/kvm/e500_emulate.c | 10 ++++++++++ >> 1 files changed, 10 insertions(+), 0 deletions(-) >> >> diff --git a/arch/powerpc/kvm/e500_emulate.c b/arch/powerpc/kvm/e500_emulate.c >> index e78f353..cefdd38 100644 >> --- a/arch/powerpc/kvm/e500_emulate.c >> +++ b/arch/powerpc/kvm/e500_emulate.c >> @@ -26,6 +26,7 @@ >> #define XOP_TLBRE 946 >> #define XOP_TLBWE 978 >> #define XOP_TLBILX 18 >> +#define XOP_EHPRIV 270 >> >> #ifdef CONFIG_KVM_E500MC >> static int dbell2prio(ulong param) >> @@ -130,6 +131,15 @@ int kvmppc_core_emulate_op(struct kvm_run *run, struct kvm_vcpu *vcpu, >> emulated = kvmppc_e500_emul_tlbivax(vcpu, ea); >> break; >> >> + case XOP_EHPRIV: > > This is supposed to check for oc, no? The other day I already sent one patch only to check OC, "KVM/PPC: emulate ehpriv". But Bharat said he's waiting for other debug patches to be reviewed. Tiejun