From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jan Kiszka Subject: Re: [PATCH] KVM: nVMX: Replace kvm_set_cr0 with vmx_set_cr0 in load_vmcs12_host_state Date: Sun, 28 Apr 2013 12:20:38 +0200 Message-ID: <517CF7F6.3070405@web.de> References: <5129361A.7090608@web.de> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="----enig2PVPUPPLRVHPFBSSGPFDH" Cc: kvm , Nadav Har'El , "Nakajima, Jun" To: Marcelo Tosatti , Gleb Natapov Return-path: Received: from mout.web.de ([212.227.15.4]:52148 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752155Ab3D1KUm (ORCPT ); Sun, 28 Apr 2013 06:20:42 -0400 In-Reply-To: <5129361A.7090608@web.de> Sender: kvm-owner@vger.kernel.org List-ID: This is an OpenPGP/MIME signed message (RFC 4880 and 3156) ------enig2PVPUPPLRVHPFBSSGPFDH Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable On 2013-02-23 22:35, Jan Kiszka wrote: > From: Jan Kiszka >=20 > Likely a typo, but a fatal one as kvm_set_cr0 performs checks on the > state transition that may prevent loading L1's cr0. >=20 > Signed-off-by: Jan Kiszka > --- > arch/x86/kvm/vmx.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) >=20 > diff --git a/arch/x86/kvm/vmx.c b/arch/x86/kvm/vmx.c > index 26d47e9..94f3b66 100644 > --- a/arch/x86/kvm/vmx.c > +++ b/arch/x86/kvm/vmx.c > @@ -7429,7 +7429,7 @@ static void load_vmcs12_host_state(struct kvm_vcp= u *vcpu, > * fpu_active (which may have changed). > * Note that vmx_set_cr0 refers to efer set above. > */ > - kvm_set_cr0(vcpu, vmcs12->host_cr0); > + vmx_set_cr0(vcpu, vmcs12->host_cr0); > /* > * If we did fpu_activate()/fpu_deactivate() during L2's run, we need= > * to apply the same changes to L1's vmcs. We just set cr0 correctly,= >=20 This one still applies, is necessary for nested unrestricted guest mode, and I'm still convinced it's an appropriate way to fix the bug. How to proceed? Jan ------enig2PVPUPPLRVHPFBSSGPFDH Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.16 (GNU/Linux) Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iEYEARECAAYFAlF89/cACgkQitSsb3rl5xTgIwCffKWeKSyz/j00gTzkKeVVpLmm FdIAoLPTjj0Adh1OCglKtixZJ/Smgcwl =iovU -----END PGP SIGNATURE----- ------enig2PVPUPPLRVHPFBSSGPFDH--