From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jan Kiszka Subject: Re: [PATCH] KVM: nVMX: Skip PF interception check when queuing during nested run Date: Sun, 28 Apr 2013 18:26:04 +0200 Message-ID: <517D4D9C.60905@web.de> References: <517CCEB9.7030504@web.de> <1B4B44D9196EFF41AE41FDA404FC0A10CA70B5@SHSMSX101.ccr.corp.intel.com> <20130428143355.GA31934@redhat.com> <1B4B44D9196EFF41AE41FDA404FC0A10CA71A5@SHSMSX101.ccr.corp.intel.com> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="----enig2FDDHNTSRIIQTTIGGCGQF" Cc: Gleb Natapov , Marcelo Tosatti , kvm , "Nakajima, Jun" To: "Ren, Yongjie" Return-path: Received: from mout.web.de ([212.227.17.11]:56888 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751673Ab3D1Q0J (ORCPT ); Sun, 28 Apr 2013 12:26:09 -0400 In-Reply-To: <1B4B44D9196EFF41AE41FDA404FC0A10CA71A5@SHSMSX101.ccr.corp.intel.com> Sender: kvm-owner@vger.kernel.org List-ID: This is an OpenPGP/MIME signed message (RFC 4880 and 3156) ------enig2FDDHNTSRIIQTTIGGCGQF Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable On 2013-04-28 18:20, Ren, Yongjie wrote: >> -----Original Message----- >> From: kvm-owner@vger.kernel.org [mailto:kvm-owner@vger.kernel.org] >> On Behalf Of Gleb Natapov >> Sent: Sunday, April 28, 2013 10:34 PM >> To: Ren, Yongjie >> Cc: Jan Kiszka; Marcelo Tosatti; kvm; Nakajima, Jun >> Subject: Re: [PATCH] KVM: nVMX: Skip PF interception check when queuin= g >> during nested run >> >> On Sun, Apr 28, 2013 at 02:30:38PM +0000, Ren, Yongjie wrote: >>>> -----Original Message----- >>>> From: kvm-owner@vger.kernel.org >> [mailto:kvm-owner@vger.kernel.org] >>>> On Behalf Of Jan Kiszka >>>> Sent: Sunday, April 28, 2013 3:25 PM >>>> To: Gleb Natapov; Marcelo Tosatti >>>> Cc: kvm; Nakajima, Jun; Ren, Yongjie >>>> Subject: [PATCH] KVM: nVMX: Skip PF interception check when queuing >>>> during nested run >>>> >>>> From: Jan Kiszka >>>> >>>> While a nested run is pending, vmx_queue_exception is only called to= >>>> requeue exceptions that were previously picked up via >>>> vmx_cancel_injection. Therefore, we must not check for PF intercepti= on >>>> by L1, possibly causing a bogus nested vmexit. >>>> >>>> Signed-off-by: Jan Kiszka >>>> --- >>>> >>>> This and the KVM_REQ_IMMEDIATE_EXIT fix allows me to boot an L2 >> Linux >>>> without problems. Yongjie, please check if it resolves your issue(s)= as >>>> well. >>>> >>> The two patches can fix my issue. When both of them are applied, I ca= n >> have >>> more tests against next branch. >> They are both applied now. >> > There's some bug in Jan's patch "Rework request for immediate exit". > When I said 2 patches can fix my issue, I meant his original two patche= s. > "Check KVM_REQ_IMMEDIATE_EXIT after enable_irq_window" works for me.=20 > "Rework request for immediate exit" patch is buggy. > In L1, I can get the following error. (also some NMI in L2.) =20 > (BTW, I'll have holidays this week. I may not track this issue this wee= k.) > [ 167.252260] NMI backtrace for cpu 1 > [ 167.253007] CPU 1 > [ 167.253007] Pid: 0, comm: swapper/1 Tainted: GF 3.8.5 #1 = Bochs Bochs > [ 167.253007] RIP: 0010:[] [] nat= ive_safe_halt+0x6/0x10 > [ 167.253007] RSP: 0018:ffff880290d51ed8 EFLAGS: 00000246 > [ 167.253007] RAX: 0000000000000000 RBX: ffff880290d50010 RCX: 0140000= 000000000 > [ 167.253007] RDX: 0000000000000000 RSI: 0140000000000000 RDI: 0000000= 000000086 > [ 167.253007] RBP: ffff880290d51ed8 R08: 0000000000000000 R09: 0000000= 000000000 > [ 167.253007] R10: 0000000000000000 R11: 0000000000000000 R12: 0000000= 000000001 > [ 167.253007] R13: 0000000000000000 R14: 0000000000000000 R15: 0000000= 000000000 > [ 167.253007] FS: 0000000000000000(0000) GS:ffff88029fc40000(0000) kn= lGS:0000000000000000 > [ 167.253007] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 > [ 167.253007] CR2: ffffffffff600400 CR3: 000000028f12d000 CR4: 0000000= 0000427e0 > [ 167.253007] DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000= 000000000 > [ 167.253007] DR3: 0000000000000000 DR6: 00000000ffff0ff0 DR7: 0000000= 000000400 > [ 167.253007] Process swapper/1 (pid: 0, threadinfo ffff880290d50000, = task ffff880290d49740) > [ 167.253007] Stack: > [ 167.253007] ffff880290d51ef8 ffffffff8101d5cf ffff880290d50010 ffff= ffff81ce0680 > [ 167.253007] ffff880290d51f28 ffffffff8101ce99 ffff880290d51f18 1de4= 884102b62f69 > [ 167.253007] 0000000000000000 0000000000000000 ffff880290d51f48 ffff= ffff81643595 > [ 167.253007] Call Trace: > [ 167.253007] [] default_idle+0x4f/0x1a0 > [ 167.253007] [] cpu_idle+0xd9/0x120 > [ 167.253007] [] start_secondary+0x24c/0x24e > [ 167.253007] Code: 00 00 00 00 00 55 48 89 e5 fa c9 c3 66 0f 1f 84 00= 00 00 00 00 55 48 89 e5 fb c9 c3 66 0f 1f 84 00 00 00 00 00 55 48 89 e5 = fb f4 c3 0f 1f 84 00 00 00 00 00 55 48 89 e5 f4 c9 c3 66 0f 1f 84 > [ 167.248015] NMI backtrace for cpu 3 > [ 167.248015] CPU 3 > [ 167.248015] Pid: 0, comm: swapper/3 Tainted: GF 3.8.5 #1 = Bochs Bochs > [ 167.248015] RIP: 0010:[] [] nat= ive_write_msr_safe+0xa/0x10 > ....... >=20 Argh, of course: We use enable_irq_window also for the NMI window in certain scenarios. So enable_nmi_window must be changed accordingly. Will send a patch. Thanks, Jan ------enig2FDDHNTSRIIQTTIGGCGQF Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.16 (GNU/Linux) Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iEYEARECAAYFAlF9TZwACgkQitSsb3rl5xRj3wCg0fRr16Fe1lZMYj8N1qd4tOoK AGIAoNB2G3lDmBtpop9o6kjlMOP1A5ZZ =J5PO -----END PGP SIGNATURE----- ------enig2FDDHNTSRIIQTTIGGCGQF--