From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paolo Bonzini Subject: Re: [PATCH 11/11] nEPT: Provide the correct exit qualification upon EPT Date: Mon, 29 Apr 2013 17:37:16 +0200 Message-ID: <517E93AC.9060301@redhat.com> References: <1366958611-6935-1-git-send-email-jun.nakajima@intel.com> <1366958611-6935-2-git-send-email-jun.nakajima@intel.com> <1366958611-6935-3-git-send-email-jun.nakajima@intel.com> <1366958611-6935-4-git-send-email-jun.nakajima@intel.com> <1366958611-6935-5-git-send-email-jun.nakajima@intel.com> <1366958611-6935-6-git-send-email-jun.nakajima@intel.com> <1366958611-6935-7-git-send-email-jun.nakajima@intel.com> <1366958611-6935-8-git-send-email-jun.nakajima@intel.com> <1366958611-6935-9-git-send-email-jun.nakajima@intel.com> <1366958611-6935-10-git-send-email-jun.nakajima@intel.com> <1366958611-6935-11-git-send-email-jun.nakajima@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: kvm@vger.kernel.org To: Jun Nakajima Return-path: Received: from mail-bk0-f45.google.com ([209.85.214.45]:44918 "EHLO mail-bk0-f45.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756655Ab3D2Phl (ORCPT ); Mon, 29 Apr 2013 11:37:41 -0400 Received: by mail-bk0-f45.google.com with SMTP id j4so2783906bkw.18 for ; Mon, 29 Apr 2013 08:37:40 -0700 (PDT) In-Reply-To: <1366958611-6935-11-git-send-email-jun.nakajima@intel.com> Sender: kvm-owner@vger.kernel.org List-ID: Il 26/04/2013 08:43, Jun Nakajima ha scritto: > diff --git a/arch/x86/kvm/paging_tmpl.h b/arch/x86/kvm/paging_tmpl.h > index e13b6c5..bd370e7 100644 > --- a/arch/x86/kvm/paging_tmpl.h > +++ b/arch/x86/kvm/paging_tmpl.h > @@ -349,7 +349,12 @@ error: > > walker->fault.vector = PF_VECTOR; > walker->fault.error_code_valid = true; > +#if PTTYPE != PTTYPE_EPT > walker->fault.error_code = errcode; > +#else > + /* Reuse bits [2:0] of EPT violation */ > + walker->fault.error_code = vcpu->arch.exit_qualification & 0x7; > +#endif > walker->fault.address = addr; > walker->fault.nested_page_fault = mmu != vcpu->arch.walk_mmu; > I'm not sure that this is a step in the right direction. errcode is dropped completely, but it would be needed to rebuild bits 3:5 of the exit qualification. Perhaps it is better to access vcpu->arch.exit_qualification in nested_ept_inject_page_fault, and mix it with the error code from walker->fault to compute bits 3:5? Paolo