From: Xiao Guangrong <xiaoguangrong@linux.vnet.ibm.com>
To: Jordan Justen <jordan.l.justen@intel.com>
Cc: kvm@vger.kernel.org, Jan Kiszka <jan.kiszka@siemens.com>
Subject: Re: [PATCH] kvm: always define KVM_CAP_READONLY_MEM
Date: Fri, 03 May 2013 14:19:59 +0800 [thread overview]
Message-ID: <5183570F.60100@linux.vnet.ibm.com> (raw)
In-Reply-To: <1367386680-30806-1-git-send-email-jordan.l.justen@intel.com>
On 05/01/2013 01:38 PM, Jordan Justen wrote:
> Don't use #ifdef __KVM_HAVE_READONLY_MEM when defining
> KVM_CAP_READONLY_MEM.
>
> Signed-off-by: Jordan Justen <jordan.l.justen@intel.com>
> Cc: Xiao Guangrong <xiaoguangrong@linux.vnet.ibm.com>
> Cc: Jan Kiszka <jan.kiszka@siemens.com>
> ---
> include/uapi/linux/kvm.h | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/include/uapi/linux/kvm.h b/include/uapi/linux/kvm.h
> index 3c56ba3..26a04e5 100644
> --- a/include/uapi/linux/kvm.h
> +++ b/include/uapi/linux/kvm.h
> @@ -655,9 +655,7 @@ struct kvm_ppc_smmu_info {
> #define KVM_CAP_PPC_GET_SMMU_INFO 78
> #define KVM_CAP_S390_COW 79
> #define KVM_CAP_PPC_ALLOC_HTAB 80
> -#ifdef __KVM_HAVE_READONLY_MEM
> #define KVM_CAP_READONLY_MEM 81
> -#endif
This is not enough since only X86 supports this feature.
I had a similar patch to change it:
https://patchwork.kernel.org/patch/1642491/
Is it good to you?
next prev parent reply other threads:[~2013-05-03 6:20 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-01 5:38 [PATCH] kvm: always define KVM_CAP_READONLY_MEM Jordan Justen
2013-05-03 6:19 ` Xiao Guangrong [this message]
2013-05-03 6:26 ` Jan Kiszka
2013-05-03 10:33 ` Xiao Guangrong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5183570F.60100@linux.vnet.ibm.com \
--to=xiaoguangrong@linux.vnet.ibm.com \
--cc=jan.kiszka@siemens.com \
--cc=jordan.l.justen@intel.com \
--cc=kvm@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox