From mboxrd@z Thu Jan 1 00:00:00 1970 From: Xiao Guangrong Subject: Re: [PATCH] kvm: always define KVM_CAP_READONLY_MEM Date: Fri, 03 May 2013 14:19:59 +0800 Message-ID: <5183570F.60100@linux.vnet.ibm.com> References: <1367386680-30806-1-git-send-email-jordan.l.justen@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Cc: kvm@vger.kernel.org, Jan Kiszka To: Jordan Justen Return-path: Received: from e28smtp08.in.ibm.com ([122.248.162.8]:44999 "EHLO e28smtp08.in.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1762185Ab3ECGUJ (ORCPT ); Fri, 3 May 2013 02:20:09 -0400 Received: from /spool/local by e28smtp08.in.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Fri, 3 May 2013 11:43:40 +0530 Received: from d28relay03.in.ibm.com (d28relay03.in.ibm.com [9.184.220.60]) by d28dlp02.in.ibm.com (Postfix) with ESMTP id 284AB394002D for ; Fri, 3 May 2013 11:50:04 +0530 (IST) Received: from d28av05.in.ibm.com (d28av05.in.ibm.com [9.184.220.67]) by d28relay03.in.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id r436Jtvk64880844 for ; Fri, 3 May 2013 11:49:56 +0530 Received: from d28av05.in.ibm.com (loopback [127.0.0.1]) by d28av05.in.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id r436K1Gx020708 for ; Fri, 3 May 2013 16:20:02 +1000 In-Reply-To: <1367386680-30806-1-git-send-email-jordan.l.justen@intel.com> Sender: kvm-owner@vger.kernel.org List-ID: On 05/01/2013 01:38 PM, Jordan Justen wrote: > Don't use #ifdef __KVM_HAVE_READONLY_MEM when defining > KVM_CAP_READONLY_MEM. > > Signed-off-by: Jordan Justen > Cc: Xiao Guangrong > Cc: Jan Kiszka > --- > include/uapi/linux/kvm.h | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/include/uapi/linux/kvm.h b/include/uapi/linux/kvm.h > index 3c56ba3..26a04e5 100644 > --- a/include/uapi/linux/kvm.h > +++ b/include/uapi/linux/kvm.h > @@ -655,9 +655,7 @@ struct kvm_ppc_smmu_info { > #define KVM_CAP_PPC_GET_SMMU_INFO 78 > #define KVM_CAP_S390_COW 79 > #define KVM_CAP_PPC_ALLOC_HTAB 80 > -#ifdef __KVM_HAVE_READONLY_MEM > #define KVM_CAP_READONLY_MEM 81 > -#endif This is not enough since only X86 supports this feature. I had a similar patch to change it: https://patchwork.kernel.org/patch/1642491/ Is it good to you?