From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jan Kiszka Subject: Re: [PATCH] kvm: always define KVM_CAP_READONLY_MEM Date: Fri, 03 May 2013 08:26:02 +0200 Message-ID: <5183587A.7070404@web.de> References: <1367386680-30806-1-git-send-email-jordan.l.justen@intel.com> <5183570F.60100@linux.vnet.ibm.com> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="----enig2AXBUOMULTPNMISFNTUKA" Cc: Jordan Justen , kvm@vger.kernel.org To: Xiao Guangrong Return-path: Received: from mout.web.de ([212.227.17.11]:53710 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1762457Ab3ECG0P (ORCPT ); Fri, 3 May 2013 02:26:15 -0400 In-Reply-To: <5183570F.60100@linux.vnet.ibm.com> Sender: kvm-owner@vger.kernel.org List-ID: This is an OpenPGP/MIME signed message (RFC 4880 and 3156) ------enig2AXBUOMULTPNMISFNTUKA Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 2013-05-03 08:19, Xiao Guangrong wrote: > On 05/01/2013 01:38 PM, Jordan Justen wrote: >> Don't use #ifdef __KVM_HAVE_READONLY_MEM when defining >> KVM_CAP_READONLY_MEM. >> >> Signed-off-by: Jordan Justen >> Cc: Xiao Guangrong >> Cc: Jan Kiszka >> --- >> include/uapi/linux/kvm.h | 2 -- >> 1 file changed, 2 deletions(-) >> >> diff --git a/include/uapi/linux/kvm.h b/include/uapi/linux/kvm.h >> index 3c56ba3..26a04e5 100644 >> --- a/include/uapi/linux/kvm.h >> +++ b/include/uapi/linux/kvm.h >> @@ -655,9 +655,7 @@ struct kvm_ppc_smmu_info { >> #define KVM_CAP_PPC_GET_SMMU_INFO 78 >> #define KVM_CAP_S390_COW 79 >> #define KVM_CAP_PPC_ALLOC_HTAB 80 >> -#ifdef __KVM_HAVE_READONLY_MEM >> #define KVM_CAP_READONLY_MEM 81 >> -#endif >=20 > This is not enough since only X86 supports this feature. >=20 > I had a similar patch to change it: > https://patchwork.kernel.org/patch/1642491/ >=20 > Is it good to you? The first hunk of that patch is unneeded (x86 always has __KVM_HAVE_READONLY_MEM set), but the third one is actually missing here.= Jan ------enig2AXBUOMULTPNMISFNTUKA Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.16 (GNU/Linux) Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iEYEARECAAYFAlGDWH4ACgkQitSsb3rl5xSoVACgzzUnQFuYXubksx+x9P1zOul2 Fo8An1y/DZ4aa9vymhr2EHVWfS3A6ThH =HSW4 -----END PGP SIGNATURE----- ------enig2AXBUOMULTPNMISFNTUKA--