* [PATCH] kvm: always define KVM_CAP_READONLY_MEM
@ 2013-05-01 5:38 Jordan Justen
2013-05-03 6:19 ` Xiao Guangrong
0 siblings, 1 reply; 4+ messages in thread
From: Jordan Justen @ 2013-05-01 5:38 UTC (permalink / raw)
To: kvm; +Cc: Jordan Justen, Xiao Guangrong, Jan Kiszka
Don't use #ifdef __KVM_HAVE_READONLY_MEM when defining
KVM_CAP_READONLY_MEM.
Signed-off-by: Jordan Justen <jordan.l.justen@intel.com>
Cc: Xiao Guangrong <xiaoguangrong@linux.vnet.ibm.com>
Cc: Jan Kiszka <jan.kiszka@siemens.com>
---
include/uapi/linux/kvm.h | 2 --
1 file changed, 2 deletions(-)
diff --git a/include/uapi/linux/kvm.h b/include/uapi/linux/kvm.h
index 3c56ba3..26a04e5 100644
--- a/include/uapi/linux/kvm.h
+++ b/include/uapi/linux/kvm.h
@@ -655,9 +655,7 @@ struct kvm_ppc_smmu_info {
#define KVM_CAP_PPC_GET_SMMU_INFO 78
#define KVM_CAP_S390_COW 79
#define KVM_CAP_PPC_ALLOC_HTAB 80
-#ifdef __KVM_HAVE_READONLY_MEM
#define KVM_CAP_READONLY_MEM 81
-#endif
#define KVM_CAP_IRQFD_RESAMPLE 82
#define KVM_CAP_PPC_BOOKE_WATCHDOG 83
#define KVM_CAP_PPC_HTAB_FD 84
--
1.7.10.4
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] kvm: always define KVM_CAP_READONLY_MEM
2013-05-01 5:38 [PATCH] kvm: always define KVM_CAP_READONLY_MEM Jordan Justen
@ 2013-05-03 6:19 ` Xiao Guangrong
2013-05-03 6:26 ` Jan Kiszka
0 siblings, 1 reply; 4+ messages in thread
From: Xiao Guangrong @ 2013-05-03 6:19 UTC (permalink / raw)
To: Jordan Justen; +Cc: kvm, Jan Kiszka
On 05/01/2013 01:38 PM, Jordan Justen wrote:
> Don't use #ifdef __KVM_HAVE_READONLY_MEM when defining
> KVM_CAP_READONLY_MEM.
>
> Signed-off-by: Jordan Justen <jordan.l.justen@intel.com>
> Cc: Xiao Guangrong <xiaoguangrong@linux.vnet.ibm.com>
> Cc: Jan Kiszka <jan.kiszka@siemens.com>
> ---
> include/uapi/linux/kvm.h | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/include/uapi/linux/kvm.h b/include/uapi/linux/kvm.h
> index 3c56ba3..26a04e5 100644
> --- a/include/uapi/linux/kvm.h
> +++ b/include/uapi/linux/kvm.h
> @@ -655,9 +655,7 @@ struct kvm_ppc_smmu_info {
> #define KVM_CAP_PPC_GET_SMMU_INFO 78
> #define KVM_CAP_S390_COW 79
> #define KVM_CAP_PPC_ALLOC_HTAB 80
> -#ifdef __KVM_HAVE_READONLY_MEM
> #define KVM_CAP_READONLY_MEM 81
> -#endif
This is not enough since only X86 supports this feature.
I had a similar patch to change it:
https://patchwork.kernel.org/patch/1642491/
Is it good to you?
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] kvm: always define KVM_CAP_READONLY_MEM
2013-05-03 6:19 ` Xiao Guangrong
@ 2013-05-03 6:26 ` Jan Kiszka
2013-05-03 10:33 ` Xiao Guangrong
0 siblings, 1 reply; 4+ messages in thread
From: Jan Kiszka @ 2013-05-03 6:26 UTC (permalink / raw)
To: Xiao Guangrong; +Cc: Jordan Justen, kvm
[-- Attachment #1: Type: text/plain, Size: 1181 bytes --]
On 2013-05-03 08:19, Xiao Guangrong wrote:
> On 05/01/2013 01:38 PM, Jordan Justen wrote:
>> Don't use #ifdef __KVM_HAVE_READONLY_MEM when defining
>> KVM_CAP_READONLY_MEM.
>>
>> Signed-off-by: Jordan Justen <jordan.l.justen@intel.com>
>> Cc: Xiao Guangrong <xiaoguangrong@linux.vnet.ibm.com>
>> Cc: Jan Kiszka <jan.kiszka@siemens.com>
>> ---
>> include/uapi/linux/kvm.h | 2 --
>> 1 file changed, 2 deletions(-)
>>
>> diff --git a/include/uapi/linux/kvm.h b/include/uapi/linux/kvm.h
>> index 3c56ba3..26a04e5 100644
>> --- a/include/uapi/linux/kvm.h
>> +++ b/include/uapi/linux/kvm.h
>> @@ -655,9 +655,7 @@ struct kvm_ppc_smmu_info {
>> #define KVM_CAP_PPC_GET_SMMU_INFO 78
>> #define KVM_CAP_S390_COW 79
>> #define KVM_CAP_PPC_ALLOC_HTAB 80
>> -#ifdef __KVM_HAVE_READONLY_MEM
>> #define KVM_CAP_READONLY_MEM 81
>> -#endif
>
> This is not enough since only X86 supports this feature.
>
> I had a similar patch to change it:
> https://patchwork.kernel.org/patch/1642491/
>
> Is it good to you?
The first hunk of that patch is unneeded (x86 always has
__KVM_HAVE_READONLY_MEM set), but the third one is actually missing here.
Jan
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 263 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] kvm: always define KVM_CAP_READONLY_MEM
2013-05-03 6:26 ` Jan Kiszka
@ 2013-05-03 10:33 ` Xiao Guangrong
0 siblings, 0 replies; 4+ messages in thread
From: Xiao Guangrong @ 2013-05-03 10:33 UTC (permalink / raw)
To: Jan Kiszka; +Cc: Jordan Justen, kvm
On 05/03/2013 02:26 PM, Jan Kiszka wrote:
> On 2013-05-03 08:19, Xiao Guangrong wrote:
>> On 05/01/2013 01:38 PM, Jordan Justen wrote:
>>> Don't use #ifdef __KVM_HAVE_READONLY_MEM when defining
>>> KVM_CAP_READONLY_MEM.
>>>
>>> Signed-off-by: Jordan Justen <jordan.l.justen@intel.com>
>>> Cc: Xiao Guangrong <xiaoguangrong@linux.vnet.ibm.com>
>>> Cc: Jan Kiszka <jan.kiszka@siemens.com>
>>> ---
>>> include/uapi/linux/kvm.h | 2 --
>>> 1 file changed, 2 deletions(-)
>>>
>>> diff --git a/include/uapi/linux/kvm.h b/include/uapi/linux/kvm.h
>>> index 3c56ba3..26a04e5 100644
>>> --- a/include/uapi/linux/kvm.h
>>> +++ b/include/uapi/linux/kvm.h
>>> @@ -655,9 +655,7 @@ struct kvm_ppc_smmu_info {
>>> #define KVM_CAP_PPC_GET_SMMU_INFO 78
>>> #define KVM_CAP_S390_COW 79
>>> #define KVM_CAP_PPC_ALLOC_HTAB 80
>>> -#ifdef __KVM_HAVE_READONLY_MEM
>>> #define KVM_CAP_READONLY_MEM 81
>>> -#endif
>>
>> This is not enough since only X86 supports this feature.
>>
>> I had a similar patch to change it:
>> https://patchwork.kernel.org/patch/1642491/
>>
>> Is it good to you?
>
> The first hunk of that patch is unneeded (x86 always has
> __KVM_HAVE_READONLY_MEM set), but the third one is actually missing here.
Yes. it is.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2013-05-03 10:33 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-05-01 5:38 [PATCH] kvm: always define KVM_CAP_READONLY_MEM Jordan Justen
2013-05-03 6:19 ` Xiao Guangrong
2013-05-03 6:26 ` Jan Kiszka
2013-05-03 10:33 ` Xiao Guangrong
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox