From mboxrd@z Thu Jan 1 00:00:00 1970 From: Xiao Guangrong Subject: Re: [PATCH] kvm: always define KVM_CAP_READONLY_MEM Date: Fri, 03 May 2013 18:33:10 +0800 Message-ID: <51839266.7070405@linux.vnet.ibm.com> References: <1367386680-30806-1-git-send-email-jordan.l.justen@intel.com> <5183570F.60100@linux.vnet.ibm.com> <5183587A.7070404@web.de> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Cc: Jordan Justen , kvm@vger.kernel.org To: Jan Kiszka Return-path: Received: from e28smtp04.in.ibm.com ([122.248.162.4]:42972 "EHLO e28smtp04.in.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750729Ab3ECKdZ (ORCPT ); Fri, 3 May 2013 06:33:25 -0400 Received: from /spool/local by e28smtp04.in.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Fri, 3 May 2013 15:58:43 +0530 Received: from d28relay02.in.ibm.com (d28relay02.in.ibm.com [9.184.220.59]) by d28dlp03.in.ibm.com (Postfix) with ESMTP id A41CB125804F for ; Fri, 3 May 2013 16:05:01 +0530 (IST) Received: from d28av04.in.ibm.com (d28av04.in.ibm.com [9.184.220.66]) by d28relay02.in.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id r43AX9IH8716662 for ; Fri, 3 May 2013 16:03:10 +0530 Received: from d28av04.in.ibm.com (loopback [127.0.0.1]) by d28av04.in.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id r43AXDgD022522 for ; Fri, 3 May 2013 20:33:13 +1000 In-Reply-To: <5183587A.7070404@web.de> Sender: kvm-owner@vger.kernel.org List-ID: On 05/03/2013 02:26 PM, Jan Kiszka wrote: > On 2013-05-03 08:19, Xiao Guangrong wrote: >> On 05/01/2013 01:38 PM, Jordan Justen wrote: >>> Don't use #ifdef __KVM_HAVE_READONLY_MEM when defining >>> KVM_CAP_READONLY_MEM. >>> >>> Signed-off-by: Jordan Justen >>> Cc: Xiao Guangrong >>> Cc: Jan Kiszka >>> --- >>> include/uapi/linux/kvm.h | 2 -- >>> 1 file changed, 2 deletions(-) >>> >>> diff --git a/include/uapi/linux/kvm.h b/include/uapi/linux/kvm.h >>> index 3c56ba3..26a04e5 100644 >>> --- a/include/uapi/linux/kvm.h >>> +++ b/include/uapi/linux/kvm.h >>> @@ -655,9 +655,7 @@ struct kvm_ppc_smmu_info { >>> #define KVM_CAP_PPC_GET_SMMU_INFO 78 >>> #define KVM_CAP_S390_COW 79 >>> #define KVM_CAP_PPC_ALLOC_HTAB 80 >>> -#ifdef __KVM_HAVE_READONLY_MEM >>> #define KVM_CAP_READONLY_MEM 81 >>> -#endif >> >> This is not enough since only X86 supports this feature. >> >> I had a similar patch to change it: >> https://patchwork.kernel.org/patch/1642491/ >> >> Is it good to you? > > The first hunk of that patch is unneeded (x86 always has > __KVM_HAVE_READONLY_MEM set), but the third one is actually missing here. Yes. it is.